Re: Fix loop test in vipw

2014-05-07 Thread Ingo Schwarze
Hi Ben, Ben Cornett wrote on Mon, Apr 28, 2014 at 08:49:36PM +: > I agree that one probably never gets a short write there in practice, > but if there is going to be a loop, it may as well be correct. That's what i think, too. So i finally committed your patch, thanks for sending it. Yours

Re: Fix loop test in vipw

2014-04-28 Thread Ben Cornett
I agree that one probably never gets a short write there in practice, but if there is going to be a loop, it may as well be correct. On Sat, Apr 26, 2014 at 10:52:50PM +0200, Ingo Schwarze wrote: > Hi, > > On Tue, Apr 22, 2014 at 01:29:03AM +, Ben Cornett wrote: > > > The following corrects th

Re: Fix loop test in vipw

2014-04-26 Thread Ingo Schwarze
Hi, On Tue, Apr 22, 2014 at 01:29:03AM +, Ben Cornett wrote: > The following corrects the termination condition on the write > loop in copyfile. >From inspection, i say the patch is clearly correct. I was unable to find any condition where the bug might actually hit: The file descriptor `t

Re: Fix loop test in vipw

2014-04-24 Thread Ben Cornett
Anybody have time to look at this? On Tue, Apr 22, 2014 at 01:29:03AM +, Ben Cornett wrote: > The following corrects the termination condition on the write > loop in copyfile. > > Index: usr.sbin/vipw/vipw.c > === > RCS file: /cvs

Fix loop test in vipw

2014-04-21 Thread Ben Cornett
The following corrects the termination condition on the write loop in copyfile. Index: usr.sbin/vipw/vipw.c === RCS file: /cvsroot/OpenBSD/src/usr.sbin/vipw/vipw.c,v retrieving revision 1.16 diff -u -p -r1.16 vipw.c --- usr.sbin/vipw/