Re: Fix includes in sys/ddb/db_variables.c

2015-03-13 Thread Steven McDonald
On Sat, 14 Mar 2015 01:49:22 -0400 "Ted Unangst" wrote: > Thanks. I restored the systm.h include instead. It's rare for C files > to include libkern headers directly. I think systm.h remains the > correct header for strcmp. Thanks for the clarification. I was going by the SYNOPSIS section of ker

Re: Fix includes in sys/ddb/db_variables.c

2015-03-13 Thread Ted Unangst
Steven McDonald wrote: > The recent change to db_variables.c to not include sys/systm.h revealed > a missing include that breaks kernel builds on macppc (and possibly > other arches). The problem is that db_variables.c makes use of > strcmp(9), which requires lib/libkern/libkern.h, and that was bei

Fix includes in sys/ddb/db_variables.c

2015-03-13 Thread Steven McDonald
The recent change to db_variables.c to not include sys/systm.h revealed a missing include that breaks kernel builds on macppc (and possibly other arches). The problem is that db_variables.c makes use of strcmp(9), which requires lib/libkern/libkern.h, and that was being included via systm.h. This