Re: Fix for POSIX conformance issue

2014-09-18 Thread Matti Karnaattu
I also noticed that these uses too setpgrp: binutils/gdb sendmail perl But these are imported so changing may make maintenance harder. However, these uses setpgrp: /usr.bin/sudo/logging.c /usr.sbin/amd/amd/amd.c: /usr.sbin/mrouted/main.c ..but looks like compiler skips it so it may be better

Re: Fix for POSIX conformance issue

2014-09-18 Thread Matti Karnaattu
>Lots of obsolete things were never added, so it makes no sense to add >them now. Ok. I didn't check old releases. I assumed that these features were removed, so that is my fault. This can be defined that old features are kept for backwards compatibility reasons, as long as it is a standard compl

Re: Fix for POSIX conformance issue

2014-09-18 Thread Ted Unangst
On Thu, Sep 18, 2014 at 13:03, Matti Karnaattu wrote: >>No, it just shouldn't be present when a conforming environment is >>requested. I've fixed to exclude it when you ask for an >>XSI conforming environment by building with _XOPEN_SOURCE defined. >>(Not sure what about you're referring to ther

Re: Fix for POSIX conformance issue

2014-09-18 Thread Matti Karnaattu
>No, it just shouldn't be present when a conforming environment is >requested. I've fixed to exclude it when you ask for an >XSI conforming environment by building with _XOPEN_SOURCE defined. >(Not sure what about you're referring to there...) http://pubs.opengroup.org/onlinepubs/9699919799/bas

Re: Fix for POSIX conformance issue

2014-09-17 Thread Philip Guenther
On Wed, Sep 17, 2014 at 12:54 PM, Matti Karnaattu wrote: >>As far as POSIX goes, setpgrp is spelled setpgid. >>Let's just replaces the instances of setpgrp() in the tree with >>setpgid() and be done with it. > > I just noted, that it was marked obsolescent in latest POSIX version. > > To make it u

Re: Fix for POSIX conformance issue

2014-09-17 Thread Matti Karnaattu
>As far as POSIX goes, setpgrp is spelled setpgid. >Let's just replaces the instances of setpgrp() in the tree with >setpgid() and be done with it. I just noted, that it was marked obsolescent in latest POSIX version. To make it unified with signal.h interface, it should be removed.from unistd.h.

Re: Fix for POSIX conformance issue

2014-09-17 Thread Todd C. Miller
On Wed, 17 Sep 2014 15:14:19 +0200, Mark Kettenis wrote: > Note that the SysV version of setpgrp is marked as an XSI extension in > the combined POSIX and X/Open specification. As such it isn't > actually part of POSIX and isn't needed for POSIX compliance. Good point. As far as POSIX goes, set

Re: Fix for POSIX conformance issue

2014-09-17 Thread Todd C. Miller
On Wed, 17 Sep 2014 13:51:37 +0200, =?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges- Anglas?= wrote: > However I don't think that changing our setpgrp definition would bring > much (any?) benefit. The mismatch here between SysV and BSD is known > since a long time, and I bet that a bunch of stuff in p

Re: Fix for POSIX conformance issue

2014-09-17 Thread Mark Kettenis
> From: j...@wxcvbn.org (=?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges-Anglas?=) > Date: Wed, 17 Sep 2014 13:51:37 +0200 > > "Todd C. Miller" writes: > > > I have no objection to this but I don't think the System-V setpgrp() > > API belongs in compat-43. We can just move it to gen/setpgrp.c. > > >

Re: Fix for POSIX conformance issue

2014-09-17 Thread Jérémie Courrèges-Anglas
"Todd C. Miller" writes: > I have no objection to this but I don't think the System-V setpgrp() > API belongs in compat-43. We can just move it to gen/setpgrp.c. > > Like Ted says, we should ready the source tree first by using > setpgid(). However, all the uses of setpgrp() in the tree are the

Re: Fix for POSIX conformance issue

2014-09-16 Thread Matti Karnaattu
All right! I'm not yet convenient with contributing open source projects with source changes, and I don't know yet what is the most efficient way to put effort. I assume that every part of the source tree has some developer responsibility who knows it best and is the most effective working on it,

Re: Fix for POSIX conformance issue

2014-09-16 Thread Todd C. Miller
I have no objection to this but I don't think the System-V setpgrp() API belongs in compat-43. We can just move it to gen/setpgrp.c. Like Ted says, we should ready the source tree first by using setpgid(). However, all the uses of setpgrp() in the tree are the equivalent of: setpgrp(0, getp

Re: Fix for POSIX conformance issue

2014-09-16 Thread Ted Unangst
On Wed, Sep 17, 2014 at 01:12, Matti Karnaattu wrote: > Hi, > > > I found that OpenBSD setpgrp is not POSIX compliant, so I write test and > make diff to fix issue. Very nice. > > > http://pubs.opengroup.org/onlinepubs/009695399/functions/setpgrp.html > > > This change removes obsolete setp

Fix for POSIX conformance issue

2014-09-16 Thread Matti Karnaattu
Hi, I found that OpenBSD setpgrp is not POSIX compliant, so I write test and make diff to fix issue. http://pubs.opengroup.org/onlinepubs/009695399/functions/setpgrp.html This change removes obsolete setpgrp, and fix /usr/src where it is used. I can compile userland and it works. Work to