Re: Fix begin of word bug in ed

2016-07-18 Thread Theo de Raadt
> If you feel bold, you can still put it in for 6.0, it's a bugfix > after all, and i don't consider it very dangerous. Then again, > if you want to be extra cautious, nothing would be wrong with > waiting until after unlock, either. that's the right attitude. Around at least every 4-5 hours for

Re: Fix begin of word bug in ed

2016-07-18 Thread Ingo Schwarze
Hi Martijn, Martijn van Duren wrote on Sun, Jul 10, 2016 at 05:36:22PM +0200: > Here's a second jab at implementing REG_STARTEND in ed. > This patch just focusses on getting REG_STARTEND in there > and the general restructuring that comes with it. Sorry for taking so long, but i finally got roun

Re: Fix begin of word bug in ed

2016-07-10 Thread Martijn van Duren
anyone? On 06/28/16 15:00, Martijn van Duren wrote: > ping > > On 06/18/16 11:13, Martijn van Duren wrote: >> Hello tech@, >> >> Here's a second jab at implementing REG_STARTEND in ed. This patch just >> focusses on getting REG_STARTEND in there and the general restructuring >> that comes with i

Re: Fix begin of word bug in ed

2016-06-28 Thread Martijn van Duren
ping On 06/18/16 11:13, Martijn van Duren wrote: > Hello tech@, > > Here's a second jab at implementing REG_STARTEND in ed. This patch just > focusses on getting REG_STARTEND in there and the general restructuring > that comes with it. > This fixes the begin of word bug similar to sed. > (Also f

Fix begin of word bug in ed

2016-06-18 Thread Martijn van Duren
Hello tech@, Here's a second jab at implementing REG_STARTEND in ed. This patch just focusses on getting REG_STARTEND in there and the general restructuring that comes with it. This fixes the begin of word bug similar to sed. (Also fix a wrong comment while here) No other changes intended. OK?

Re: Fix begin of word bug in ed

2016-06-01 Thread Ingo Schwarze
Hi Martijn, Martijn van Duren wrote on Sun, May 29, 2016 at 03:18:57PM +0200: > 1) It removes the isbinary test and the accompanying > NUL_TO_NEWLINE/NEWLINE_TO_NUL conversions. If a NUL-byte is found in a > text ed detects it as a binary file and converts every NUL to a newline > prior to doing

Re: Fix begin of word bug in ed

2016-05-29 Thread Martijn van Duren
Here's an updated diff based on a comment I found in vi's substitute code. When a 0-length match is found directly on the position where the previous non-0-length match ended it should skip that match. Consider the following: text: aabb command: s/a*/X/g without check: XXbXbX with check: XbXbX T

Fix begin of word bug in ed

2016-05-29 Thread Martijn van Duren
Hello tech@, Here's a first attempt at fixing the begin of word bug as also found in sed. It does a little more then I initially sed^ht out to do, but I also found some other unexpected behaviour. 1) It removes the isbinary test and the accompanying NUL_TO_NEWLINE/NEWLINE_TO_NUL conversions. If a