Re: Fix/simplify physio() error path handling

2011-07-03 Thread Matthew Dempsky
On Sun, Jul 3, 2011 at 12:17 PM, Kenneth R Westerback wrote: > My only concern would be not having B_ERROR/b_error set when brelvp() is > called on the buf. No idea if this would change the handling of the buf. That should be fine. brelvp() doesn't look at B_ERROR/b_error at all. I'm pretty sur

Re: Fix/simplify physio() error path handling

2011-07-03 Thread Kenneth R Westerback
On Sat, Jul 02, 2011 at 02:13:30PM -0700, Matthew Dempsky wrote: > In physio(), the after_unlock code assumes that b_resid is valid, but > that value is only assigned if we actually call (*strategy)(), which > doesn't happen if uvm_vslock_device() fails. > > None of that error handling code is act

Fix/simplify physio() error path handling

2011-07-02 Thread Matthew Dempsky
In physio(), the after_unlock code assumes that b_resid is valid, but that value is only assigned if we actually call (*strategy)(), which doesn't happen if uvm_vslock_device() fails. None of that error handling code is actually needed if uvm_vslock_device() fails, so just break out of the loop in