Re: First step towards improved unlocking in the VFS layer.

2023-06-13 Thread Bob Beck
> On Jun 13, 2023, at 7:59 AM, Theo de Raadt wrote: > > Thordur I. Bjornsson wrote: > >> On Mon, Jun 12, 2023 at 9:15 PM Bob Beck wrote: >>> >>> On Mon, Jun 12, 2023 at 11:01:18AM -0600, Theo de Raadt wrote: + KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche");

Re: First step towards improved unlocking in the VFS layer.

2023-06-13 Thread Theo de Raadt
Thordur I. Bjornsson wrote: > On Mon, Jun 12, 2023 at 9:15 PM Bob Beck wrote: > > > > On Mon, Jun 12, 2023 at 11:01:18AM -0600, Theo de Raadt wrote: > > > + KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche"); > > > That part of the diff is not OK. If everyone did this, we wou

Re: First step towards improved unlocking in the VFS layer.

2023-06-12 Thread Thordur I. Bjornsson
On Mon, Jun 12, 2023 at 9:15 PM Bob Beck wrote: > > On Mon, Jun 12, 2023 at 11:01:18AM -0600, Theo de Raadt wrote: > > + KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche"); > > That part of the diff is not OK. If everyone did this, we would have a > > mess on our hands. > (or I

Re: First step towards improved unlocking in the VFS layer.

2023-06-12 Thread Bob Beck
On Mon, Jun 12, 2023 at 11:01:18AM -0600, Theo de Raadt wrote: > + KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche"); > > That part of the diff is not OK. If everyone did this, we would have a > mess on our hands. Yeah, thats me nodding to my own past stupidity ;) changed t

Re: First step towards improved unlocking in the VFS layer.

2023-06-12 Thread Theo de Raadt
+ KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche"); That part of the diff is not OK. If everyone did this, we would have a mess on our hands.

First step towards improved unlocking in the VFS layer.

2023-06-12 Thread Bob Beck
Minimal diff, further cleanup and dead code removal to follow. --- sys/kern/vfs_syscalls.c | 7 +++ sys/sys/mount.h | 2 +- sys/ufs/ffs/ffs_softdep.c | 2 ++ sys/ufs/ffs/ffs_vfsops.c | 16 +++- 4 files changed, 9 insertions(+), 18 deletions(-) diff --git a/sys/ker