Re: Explicitly cast the return variable in tls_load_file()

2016-10-03 Thread kinichiro inoguchi
I could have an answer that this compilation error was a bug of compiler, and that bug will be tracked. https://software.intel.com/en-us/forums/intel-c-compiler/topic/698109 I saw the type of buf was changed in cvs, then I can avoid this compilation problem. Thanks. Kinichiro

Re: Explicitly cast the return variable in tls_load_file()

2016-10-02 Thread kinichiro inoguchi
Thanks, that is apparently better than I suggested and reasonable. And I confirmed it can also avoid the issue. I appreciate if this is applied. And, yes I believe compilation error is bug of compiler, not source code. I posted this compilation error to Intel C++ compiler forum on Sunday. https://

Re: Explicitly cast the return variable in tls_load_file()

2016-10-02 Thread Ted Unangst
Brent Cook wrote: > ​Why not just make the variable type match the return type to begin with? sure, that's reasonable. > > ​--- a/src/lib/libtls/tls_util.c > +++ b/src/lib/libtls/tls_util.c > @@ -105,7 +105,8 @@ tls_load_file(const char *name, size_t *len, char > *password) > FILE *fp; >

Re: Explicitly cast the return variable in tls_load_file()

2016-10-02 Thread Brent Cook
On Sun, Oct 02, 2016 at 08:50:39AM -0500, Brent Cook wrote: > On Sat, Oct 1, 2016 at 7:12 PM, Ted Unangst wrote: > > > Kinichiro Inoguchi wrote: > > > I would like to cast the return variable explicitly in tls_load_file(). > > > This fix also avoiding Intel C++ compiler "assertion failed" describe

Re: Explicitly cast the return variable in tls_load_file()

2016-10-02 Thread Brent Cook
On Sat, Oct 1, 2016 at 7:12 PM, Ted Unangst wrote: > Kinichiro Inoguchi wrote: > > I would like to cast the return variable explicitly in tls_load_file(). > > This fix also avoiding Intel C++ compiler "assertion failed" described > here. > > https://github.com/libressl-portable/portable/issues/20

Re: Explicitly cast the return variable in tls_load_file()

2016-10-01 Thread Ted Unangst
Kinichiro Inoguchi wrote: > I would like to cast the return variable explicitly in tls_load_file(). > This fix also avoiding Intel C++ compiler "assertion failed" described here. > https://github.com/libressl-portable/portable/issues/209#issuecomment-249587024 This is a compiler bug? The code does

Explicitly cast the return variable in tls_load_file()

2016-10-01 Thread Kinichiro Inoguchi
I would like to cast the return variable explicitly in tls_load_file(). This fix also avoiding Intel C++ compiler "assertion failed" described here. https://github.com/libressl-portable/portable/issues/209#issuecomment-249587024 ok ? Index: tls_util.c ==