Re: Double underlining and strikeout console patch

2023-01-30 Thread Crystal Kolipe
On Mon, Jan 30, 2023 at 09:15:51PM -0300, Crystal Kolipe wrote: > But just because the original goal is well within sight, I didn't see that > as a reason to stop. Just to clarify, I mean a reason to stop writing further code for evaluation. Not 'not a reason to stop', as in continue bloating the

Re: Double underlining and strikeout console patch

2023-01-30 Thread Crystal Kolipe
On Mon, Jan 30, 2023 at 04:53:02PM -0700, Theo de Raadt wrote: > Whoosh, you missed the point. > > I've used xterm for decades and never used any of that. > > If those operations turn into "no-op" or perform the minimum rendering > change, it is still valid xterm escape processing. > > There is

Re: Double underlining and strikeout console patch

2023-01-30 Thread Theo de Raadt
Whoosh, you missed the point. I've used xterm for decades and never used any of that. If those operations turn into "no-op" or perform the minimum rendering change, it is still valid xterm escape processing. There is a difference betwen parsing an escape sequence, and performing a discrete & spe

Re: Double underlining and strikeout console patch

2023-01-30 Thread Crystal Kolipe
On Tue, Jan 31, 2023 at 12:03:53AM +0100, Christian Weisgerber wrote: > Crystal Kolipe: > > > Here is the latest version of the double underline and strikeout parts of my > > console patchset. > > I'm sorry, but I gotta ask: Who or what uses something like this?? It's useful on displays that lac

Re: Double underlining and strikeout console patch

2023-01-30 Thread Christian Weisgerber
Crystal Kolipe: > Here is the latest version of the double underline and strikeout parts of my > console patchset. I'm sorry, but I gotta ask: Who or what uses something like this?? Offhand, I don't even know if xterm can do it. If you want this kind of typographic detail, shouldn't you be usin

Double underlining and strikeout console patch

2023-01-30 Thread Crystal Kolipe
Here is the latest version of the double underline and strikeout parts of my console patchset. Previously, the double underline was always painted two pixels above the normal underline. This worked well for most font sizes, but to improve the visual effect with the smallest and largest fonts the