Re: Document ifc_list immutability

2022-11-08 Thread Vitaliy Makkoveev
ok > On 8 Nov 2022, at 21:38, Klemens Nanni wrote: > > On Tue, Nov 08, 2022 at 09:34:36PM +0300, Vitaliy Makkoveev wrote: >>> On 8 Nov 2022, at 21:26, Klemens Nanni wrote: >>> >>> On Tue, Nov 08, 2022 at 09:18:47PM +0300, Vitaliy Makkoveev wrote: > On 8 Nov 2022, at 21:08, Klemens Nanni w

Re: Document ifc_list immutability

2022-11-08 Thread Klemens Nanni
On Tue, Nov 08, 2022 at 09:34:36PM +0300, Vitaliy Makkoveev wrote: > > On 8 Nov 2022, at 21:26, Klemens Nanni wrote: > > > > On Tue, Nov 08, 2022 at 09:18:47PM +0300, Vitaliy Makkoveev wrote: > >>> On 8 Nov 2022, at 21:08, Klemens Nanni wrote: > >>> > >>> Now properly. How about a single comme

Re: Document ifc_list immutability

2022-11-08 Thread Vitaliy Makkoveev
> On 8 Nov 2022, at 21:26, Klemens Nanni wrote: > > On Tue, Nov 08, 2022 at 09:18:47PM +0300, Vitaliy Makkoveev wrote: >>> On 8 Nov 2022, at 21:08, Klemens Nanni wrote: >>> >>> Now properly. How about a single comment block at the top instead of >>> repeating it for every struct? >>> >>> >>

Re: Document ifc_list immutability

2022-11-08 Thread Klemens Nanni
On Tue, Nov 08, 2022 at 09:18:47PM +0300, Vitaliy Makkoveev wrote: > > On 8 Nov 2022, at 21:08, Klemens Nanni wrote: > > > > Now properly. How about a single comment block at the top instead of > > repeating it for every struct? > > > > > > You forgot to mark [I] `if_cloners’ within net/if.c.

Re: Document ifc_list immutability

2022-11-08 Thread Vitaliy Makkoveev
> On 8 Nov 2022, at 21:08, Klemens Nanni wrote: > > Now properly. How about a single comment block at the top instead of > repeating it for every struct? > > You forgot to mark [I] `if_cloners’ within net/if.c. > diff --git a/sys/net/if_var.h b/sys/net/if_var.h > index 28514a0bfcd..6272be882

Document ifc_list immutability

2022-11-08 Thread Klemens Nanni
Now properly. How about a single comment block at the top instead of repeating it for every struct? diff --git a/sys/net/if_var.h b/sys/net/if_var.h index 28514a0bfcd..6272be882f4 100644 --- a/sys/net/if_var.h +++ b/sys/net/if_var.h @@ -73,6 +73,18 @@ * interfaces. These routines live in the