Re: Do not use rn_refines in if.c

2016-10-14 Thread Martin Pieuchot
On 10/10/2016 20:15, Claudio Jeker wrote: So rn_refines() is a function from the deep underbelly of radix code. In my opinion if.c should not use this function especially now that we use art for routing table lookups. Instead I implemented a simple ifa_netmask_cmp() function that does what the

Re: Do not use rn_refines in if.c

2016-10-10 Thread Alexander Bluhm
On Mon, Oct 10, 2016 at 08:15:19PM +0200, Claudio Jeker wrote: > So rn_refines() is a function from the deep underbelly of radix code. > In my opinion if.c should not use this function especially now that we use > art for routing table lookups. Instead I implemented a simple > ifa_netmask_cmp() fun

Re: Do not use rn_refines in if.c

2016-10-10 Thread Mike Belopuhov
On 10 October 2016 at 20:15, Claudio Jeker wrote: > So rn_refines() is a function from the deep underbelly of radix code. > In my opinion if.c should not use this function especially now that we use > art for routing table lookups. Instead I implemented a simple > ifa_netmask_cmp() function that d

Do not use rn_refines in if.c

2016-10-10 Thread Claudio Jeker
So rn_refines() is a function from the deep underbelly of radix code. In my opinion if.c should not use this function especially now that we use art for routing table lookups. Instead I implemented a simple ifa_netmask_cmp() function that does what the code expects and compares the two netmasks. It