Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Miod Vallat
Aside from the coding style, which could benefit as a minimum from not having instructions on the same line as labels, but would also benefit from explicit checks against NULL or zero instead of (!foo) in many places > Index: lib/libssl/src/crypto/dstu/dstu_ameth.c > +static int > +dstu_asn1_

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Ignat Korchagin
I'm the author of the code and comfortable with any license most suitable for LibreSSL project. What would you recommend for such code? Regards, Ignat 2016-02-29 15:11 GMT+00:00 Bob Beck : > Just quickly, because there may be other issues: > > +/* > + * ==

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Bob Beck
On Mon, Feb 29, 2016 at 08:17:31AM -0700, Theo de Raadt wrote: > > Just quickly, because there may be other issues: > > > > +/* > > + * === > > + * Author: Ignat Korchagin . > > + * This file is distributed under the same license as OpenSSL.

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Theo de Raadt
> Just quickly, because there may be other issues: > > +/* > + * === > + * Author: Ignat Korchagin . > + * This file is distributed under the same license as OpenSSL. > + * === > + */ >

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Bob Beck
Just quickly, because there may be other issues: +/* + * === + * Author: Ignat Korchagin . + * This file is distributed under the same license as OpenSSL. + * === + */ The above is not

DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Sergey Prysiazhnyi
Hello guys. Just after 5.9 tag, sending you to consider the Subject patch for -current, requesting to commit it to the LibreSSL upstream. Together with prepared and remediation patch (see inline, the original is here: https://github.com/libressl-portable/openbsd/compare/master...crypto-org-ua:dst