Re: Convert SO_RTABLE protocol level to SOL_SOCKET

2011-06-21 Thread Mike Belopuhov
On Mon, Jun 20, 2011 at 20:22 +0200, Claudio Jeker wrote: > On Mon, Jun 20, 2011 at 06:30:11PM +0200, Mike Belopuhov wrote: > > Now that we support SO_RTABLE on the socket level, it makes > > sense to cleanup the tree. OK? > > > > The if (getsockopt() && errno != ENOPROTOOPT) constructs are in m

Re: Convert SO_RTABLE protocol level to SOL_SOCKET

2011-06-20 Thread Claudio Jeker
On Mon, Jun 20, 2011 at 06:30:11PM +0200, Mike Belopuhov wrote: > Now that we support SO_RTABLE on the socket level, it makes > sense to cleanup the tree. OK? > The if (getsockopt() && errno != ENOPROTOOPT) constructs are in my opinion evil but the sa_family == AF_INET check is not much better b

Convert SO_RTABLE protocol level to SOL_SOCKET

2011-06-20 Thread Mike Belopuhov
Now that we support SO_RTABLE on the socket level, it makes sense to cleanup the tree. OK? Index: sbin/ping/ping.c === RCS file: /home/cvs/src/sbin/ping/ping.c,v retrieving revision 1.88 diff -u -p -r1.88 ping.c --- sbin/ping/ping.c