On Thu, Apr 20, 2023 at 03:11:15PM +0300, Vitaliy Makkoveev wrote:
> Now rtable_*source() are polished, so we could push this diff to tree.
>
> ok?
OK bluhm@
> On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote:
> > It seems rt_setsource() needs some attention, but sysctl_source()
Now rtable_*source() are polished, so we could push this diff to tree.
ok?
On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote:
> It seems rt_setsource() needs some attention, but sysctl_source() could
> be called with shared netlock just now.
>
> Index: sys/net/rtsock.c
>
On Tue, Apr 18, 2023 at 03:36:09PM +0200, Alexander Bluhm wrote:
> On Mon, Apr 17, 2023 at 05:53:28PM +0200, Alexander Bluhm wrote:
> > On Mon, Apr 17, 2023 at 04:32:13PM +0200, Alexander Bluhm wrote:
> > > On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote:
> > > > It seems rt_setso
On Mon, Apr 17, 2023 at 05:53:28PM +0200, Alexander Bluhm wrote:
> On Mon, Apr 17, 2023 at 04:32:13PM +0200, Alexander Bluhm wrote:
> > On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote:
> > > It seems rt_setsource() needs some attention, but sysctl_source() could
> > > be called wi
On Mon, Apr 17, 2023 at 06:33:50PM +0300, Vitaliy Makkoveev wrote:
> However, the renaming of `source' to `ar_source' diff is pretty small.
> We use 'art_root' structure in regress/sys/net/rtable/delete and in
> usr.bin/netstat/ but we don't touch `source'.
OK bluhm@
> Index: sys/net/art.h
>
On Mon, Apr 17, 2023 at 04:32:13PM +0200, Alexander Bluhm wrote:
> On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote:
> > It seems rt_setsource() needs some attention, but sysctl_source() could
> > be called with shared netlock just now.
>
> I think rtable_setsource() is not MP saf
On Mon, Apr 17, 2023 at 04:32:13PM +0200, Alexander Bluhm wrote:
> On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote:
> > It seems rt_setsource() needs some attention, but sysctl_source() could
> > be called with shared netlock just now.
>
> I think rtable_setsource() is not MP saf
On Mon, Apr 17, 2023 at 02:36:57AM +0300, Vitaliy Makkoveev wrote:
> It seems rt_setsource() needs some attention, but sysctl_source() could
> be called with shared netlock just now.
I think rtable_setsource() is not MP safe. It is documented as [K]
kernel lock. But that is not true and makes no
It seems rt_setsource() needs some attention, but sysctl_source() could
be called with shared netlock just now.
Index: sys/net/rtsock.c
===
RCS file: /cvs/src/sys/net/rtsock.c,v
retrieving revision 1.359
diff -u -p -r1.359 rtsock.c
--
