On Thu, Feb 19, 2015 at 08:01:01PM -0500, Ted Unangst wrote:
> Yes. That is consistent with other callers.
OK bluhm@
> Index: pf_ioctl.c
> ===
> RCS file: /cvs/src/sys/net/pf_ioctl.c,v
> retrieving revision 1.282
> diff -u -p -r1.282
Alexander Bluhm wrote:
> On Thu, Feb 19, 2015 at 06:31:01PM -0500, Ted Unangst wrote:
> > Maxime Villard wrote:
> > > Hi,
> > > I put here a bug among others:
> >
> > Thanks. I see two cases here where we need to pool_put the qs. Also need to
> > change return to break so that we release the rwloc
On Thu, Feb 19, 2015 at 06:31:01PM -0500, Ted Unangst wrote:
> Maxime Villard wrote:
> > Hi,
> > I put here a bug among others:
>
> Thanks. I see two cases here where we need to pool_put the qs. Also need to
> change return to break so that we release the rwlock.
>
>
> Index: pf_ioctl.c
> ==
On Thu, 19 Feb 2015 18:31:01 -0500, "Ted Unangst" wrote:
> Thanks. I see two cases here where we need to pool_put the qs. Also need to
> change return to break so that we release the rwlock.
Not to mention the splx(). OK millert@
- todd
Maxime Villard wrote:
> Hi,
> I put here a bug among others:
Thanks. I see two cases here where we need to pool_put the qs. Also need to
change return to break so that we release the rwlock.
Index: pf_ioctl.c
===
RCS file: /cvs/src/
Hi,
I put here a bug among others:
-- sys/net/pf_ioctl.c --
1027qs = pool_get(&pf_queue_pl, PR_WAITOK|PR_LIMITFAIL|PR_ZERO);
if (qs == NULL) {
error = ENOMEM;
break;
