Re: BSD strip(1) error handling

2012-03-02 Thread Tobias Ulmer
Too bad, I didn't know that obscure rule :( I've checked GNU strip and it also continues on errors. Thanks for reviewing this patch!

Re: BSD strip(1) error handling

2012-03-01 Thread Philip Guenther
On Thu, Mar 1, 2012 at 6:29 PM, Tobias Ulmer wrote: ... > strip also tries to loop over multiple files despite previous errors and > returns an error code in the end. There are gotos sprinkled throughout > to support this. I don't think that is helpful at all and have changed > it to immediately t

BSD strip(1) error handling

2012-03-01 Thread Tobias Ulmer
strip's error handling appears to be questionable. The ERROR() define has a continue statement at the end, yet in use there are statements behind it. gcc2 does not warn about this. strip also tries to loop over multiple files despite previous errors and returns an error code in the end. There are