Re: Avoid memory leak in nfs_serv.c

2009-07-30 Thread David
On Thu, 2009-07-30 at 17:37 -0600, Theo de Raadt wrote: > Follow the flow of the code: > > again: > ... > > if (cookies) { > free((caddr_t)cookies, M_TEMP); > cookies = NULL; > } > > A kernel double free. I doubt it. > Holy shit that was

Re: Avoid memory leak in nfs_serv.c

2009-07-30 Thread Theo de Raadt
> >From NetBSD. > > Index: nfs_serv.c > === > RCS file: /cvs/src/sys/nfs/nfs_serv.c,v > retrieving revision 1.77 > diff -u -p -r1.77 nfs_serv.c > --- nfs_serv.c20 Jul 2009 16:49:40 - 1.77 > +++ nfs_serv.c30 Ju

Avoid memory leak in nfs_serv.c

2009-07-30 Thread David
>From NetBSD. Index: nfs_serv.c === RCS file: /cvs/src/sys/nfs/nfs_serv.c,v retrieving revision 1.77 diff -u -p -r1.77 nfs_serv.c --- nfs_serv.c 20 Jul 2009 16:49:40 - 1.77 +++ nfs_serv.c 30 Jul 2009 23:11:33 - @@ -2489