Re: AES-GCM Part 1: AES-GCM implementation

2010-09-02 Thread Mike Belopuhov
Latest version. No changes since the last one, except for the fixed CRYPTO_ALGORITHM_MAX. OK to commit? :) Index: conf/files === RCS file: /home/cvs/src/sys/conf/files,v retrieving revision 1.499 diff -u -p -u -p -r1.499 files --- co

Re: AES-GCM Part 1: AES-GCM implementation

2010-08-24 Thread Mike Belopuhov
On Tue, Aug 24, 2010 at 2:52 AM, Tobias Weingartner wrote: > Ok, the ..._MAX define was == to the last define before, now it's > one more than the largest? Did you adjust the code to match? Not > that I can see... > > -Toby. > Oh, nice catch, indeed!

Re: AES-GCM Part 1: AES-GCM implementation

2010-08-23 Thread Tobias Weingartner
Not sure if anyone has responded yet... been a while since I've actually had time to read any of these lists. :( Anyways, comments inline On Friday, August 20, Mike Belopuhov wrote: > > Index: crypto/cryptodev.h > === > RCS file: /

Re: AES-GCM Part 1: AES-GCM implementation

2010-08-23 Thread Mark Kettenis
> Date: Mon, 23 Aug 2010 14:09:03 +0200 > From: Mike Belopuhov > > On Sun, Aug 22, 2010 at 19:40 +, Christian Weisgerber wrote: > > Mike Belopuhov wrote: > > > > > This is a first diff of a series that brings support for the > > > Galois/Counter Mode for AES in OpenBSD. > > > > \o/ > > >

Re: AES-GCM Part 1: AES-GCM implementation

2010-08-23 Thread Mike Belopuhov
On Sun, Aug 22, 2010 at 19:40 +, Christian Weisgerber wrote: > Mike Belopuhov wrote: > > > This is a first diff of a series that brings support for the > > Galois/Counter Mode for AES in OpenBSD. > > \o/ > > Comments below. > thanks for the feedback! > > --- crypto/cryptosoft.c 2 Jul

Re: AES-GCM Part 1: AES-GCM implementation

2010-08-22 Thread Christian Weisgerber
Mike Belopuhov wrote: > This is a first diff of a series that brings support for the > Galois/Counter Mode for AES in OpenBSD. \o/ Comments below. > --- crypto/cryptosoft.c 2 Jul 2010 02:40:15 - 1.54 > +++ crypto/cryptosoft.c 20 Aug 2010 15:38:50 - > @@ -492,6 +492,14

Re: AES-GCM Part 1: AES-GCM implementation

2010-08-20 Thread Mike Belopuhov
On Fri, Aug 20, 2010 at 20:58 +0200, Mike Belopuhov wrote: > - requires input data to be continuous, i.e.: > given block C of 16 bytes which is a concatenation of blocks > A an B (C = A || B): GMAC(C) =/= GMAC(B, GMAC(A, Z)), where > GMAC(X, Y) denotes GMAC application to the block

AES-GCM Part 1: AES-GCM implementation

2010-08-20 Thread Mike Belopuhov
Hi, This is a first diff of a series that brings support for the Galois/Counter Mode for AES in OpenBSD. Intro = For those unfamiliar with GCM, I'm going to quote Wikipedia[1]: GCM mode (Galois/Counter Mode) is a mode of operation for symmetri key cryptographic block ciphers. It is an a