Re: 32-bit ucas on amd64

2012-11-18 Thread Paul Irofti
Okay? diff --git sys/arch/amd64/include/atomic.h sys/arch/amd64/include/atomic.h index effbb04..4cf6563 100644 --- sys/arch/amd64/include/atomic.h +++ sys/arch/amd64/include/atomic.h @@ -90,6 +90,17 @@ x86_atomic_clearbits_u32(volatile u_int32_t *ptr, u_int32_t bits) __asm __volatile(LOC

Re: 32-bit ucas on amd64

2012-11-18 Thread Paul Irofti
On Sun, Nov 18, 2012 at 11:50:36AM +0100, Mark Kettenis wrote: > > Date: Sat, 17 Nov 2012 20:40:24 +0200 > > From: Paul Irofti > > > > > 2/ Split the i386 atomic_ucas_32 into two, one that's pcb aware and one > > > that's not. And use the pcb aware one for the futex and the other one > > > for th

Re: 32-bit ucas on amd64

2012-11-18 Thread Mark Kettenis
> Date: Sat, 17 Nov 2012 20:40:24 +0200 > From: Paul Irofti > > > 2/ Split the i386 atomic_ucas_32 into two, one that's pcb aware and one > > that's not. And use the pcb aware one for the futex and the other one > > for the acpi locking. And of course the amd64 function in the diff > > bellow wil

Re: 32-bit ucas on amd64

2012-11-18 Thread Mark Kettenis
> Date: Sat, 17 Nov 2012 19:48:36 +0200 > From: Paul Irofti > > On Fri, Sep 21, 2012 at 12:15:51PM +0200, Mark Kettenis wrote: > > > Date: Wed, 19 Sep 2012 15:41:09 +0300 > > > From: Paul Irofti > > > > > > I need this for acpi locking, okay? > > > > > > (I'd also like to get rid of the silly

Re: 32-bit ucas on amd64

2012-11-17 Thread Paul Irofti
> 2/ Split the i386 atomic_ucas_32 into two, one that's pcb aware and one > that's not. And use the pcb aware one for the futex and the other one > for the acpi locking. And of course the amd64 function in the diff > bellow will match the non-pcb one from i386. With the convention that the 'u' in

Re: 32-bit ucas on amd64

2012-11-17 Thread Paul Irofti
On Fri, Sep 21, 2012 at 12:15:51PM +0200, Mark Kettenis wrote: > > Date: Wed, 19 Sep 2012 15:41:09 +0300 > > From: Paul Irofti > > > > I need this for acpi locking, okay? > > > > (I'd also like to get rid of the silly x86_* prefix to match the i386 > > function name, but that's a different topic

Re: 32-bit ucas on amd64

2012-09-21 Thread Mark Kettenis
> Date: Wed, 19 Sep 2012 15:41:09 +0300 > From: Paul Irofti > > I need this for acpi locking, okay? > > (I'd also like to get rid of the silly x86_* prefix to match the i386 > function name, but that's a different topic) I disagree with the off-topic bit. What we do need is a consistent set of

32-bit ucas on amd64

2012-09-19 Thread Paul Irofti
I need this for acpi locking, okay? (I'd also like to get rid of the silly x86_* prefix to match the i386 function name, but that's a different topic) Index: arch/amd64/include/atomic.h === RCS file: /cvs/src/sys/arch/amd64/include/a