Re: [patch mountd.c] replace malloc & memset with calloc

2014-04-22 Thread peter
Thanks Bob. I'll do that. Quoting Bob Beck : Note you can often have this problem if you cut and paste your diff into a mail message Normally best to use something that allows you to just include the diff from a file inline. To check it, mail *yourself* the diff. If you can save the email mes

Re: [patch mountd.c] replace malloc & memset with calloc

2014-04-22 Thread peter
Damn it - that's my bad. I'll stop sending more of these patches (i have a lot) until I get that sorted. Apologies! Quoting Ted Unangst : On Tue, Apr 22, 2014 at 15:49, pe...@petermalone.org wrote: Hi, Another malloc & memset to calloc cleanup. This time in mountd.c Can you be careful ab

Re: [patch mountd.c] replace malloc & memset with calloc

2014-04-22 Thread Bob Beck
Note you can often have this problem if you cut and paste your diff into a mail message Normally best to use something that allows you to just include the diff from a file inline. To check it, mail *yourself* the diff. If you can save the email message raw and apply the diff just by running patch

Re: [patch mountd.c] replace malloc & memset with calloc

2014-04-22 Thread Ted Unangst
On Tue, Apr 22, 2014 at 15:49, pe...@petermalone.org wrote: > Hi, > > Another malloc & memset to calloc cleanup. This time in mountd.c Can you be careful about whitespace? Your diffs have spaces instead of tabs and don't apply. The ones you've sent I can hand apply, but for future diffs please w

[patch mountd.c] replace malloc & memset with calloc

2014-04-22 Thread peter
Hi, Another malloc & memset to calloc cleanup. This time in mountd.c Index: mountd.c === RCS file: /cvs/src/sbin/mountd/mountd.c,v retrieving revision 1.73 diff -u -p -u -r1.73 mountd.c --- mountd.c24 Mar 2014 00:19:48 -