Re: [patch] tcpdump segfault on invalid DECnet packet

2015-10-24 Thread Sebastian Benoit
Stuart Henderson(st...@openbsd.org) on 2015.10.20 16:37:58 +0100: > On 2015/10/14 11:11, Kevin Reay wrote: > > Thanks for the review and feedback. > > Updated patch with removed whitespace changes included. > > This is fine with me. Any OKs to commit it? yes, ok > > Index: print-decnet.c > > ==

Re: [patch] tcpdump segfault on invalid DECnet packet

2015-10-20 Thread Stuart Henderson
On 2015/10/14 11:11, Kevin Reay wrote: > Thanks for the review and feedback. > Updated patch with removed whitespace changes included. This is fine with me. Any OKs to commit it? > Index: print-decnet.c > === > RCS file: /cvs/src/us

Re: [patch] tcpdump segfault on invalid DECnet packet

2015-10-14 Thread Kevin Reay
Thanks for the review and feedback. Updated patch with removed whitespace changes included. On Wed, Oct 14, 2015 at 11:55:58AM +0100, Stuart Henderson wrote: > unnecessary whitespace change (new one is wrong) Index: print-decnet.c ===

Re: [patch] tcpdump segfault on invalid DECnet packet

2015-10-14 Thread Stuart Henderson
On 2015/10/11 05:02, Kevin Reay wrote: > Fix a tcpdump segfault when attempting to print an invalid DECnet > packet. > > DECnet packet printing code could cause a segfault on an impossibly > large packet from a specifically crafted packet. > > The segfault would occur in tcpdump.c:default_print()

[patch] tcpdump segfault on invalid DECnet packet

2015-10-11 Thread Kevin Reay
Fix a tcpdump segfault when attempting to print an invalid DECnet packet. DECnet packet printing code could cause a segfault on an impossibly large packet from a specifically crafted packet. The segfault would occur in tcpdump.c:default_print() called by print-decnet.c:decnet_print(). Patch buil