Re: [patch] tcpdump print-atalk segfaults

2015-11-09 Thread Mike Belopuhov
On 9 November 2015 at 01:27, Kevin Reay wrote: > On Sun, Nov 8, 2015 at 4:58 PM, Mike Belopuhov wrote: >> Do you have a library of pcaps available somewhere? > > Just a small local set that I've built up for testing. > > Is there interest in having them online somewhere? Well, we have no other w

Re: [patch] tcpdump print-atalk segfaults

2015-11-08 Thread Kevin Reay
On Sun, Nov 8, 2015 at 4:58 PM, Mike Belopuhov wrote: > Do you have a library of pcaps available somewhere? Just a small local set that I've built up for testing. Is there interest in having them online somewhere?

Re: [patch] tcpdump print-atalk segfaults

2015-11-08 Thread Mike Belopuhov
On 9 November 2015 at 00:51, Kevin Reay wrote: > On Sun, Nov 08, 2015 at 11:44:48PM +0100, Christian Weisgerber wrote: >> In my tree, I'm still lugging along the patch below. This is >> strictly equivalent to mikeb@'s change "Catch up with the BPF_ALIGNMENT >> switch to the uint32_t" to print-{ip

Re: [patch] tcpdump print-atalk segfaults

2015-11-08 Thread Kevin Reay
On Sun, Nov 08, 2015 at 11:44:48PM +0100, Christian Weisgerber wrote: > In my tree, I'm still lugging along the patch below. This is > strictly equivalent to mikeb@'s change "Catch up with the BPF_ALIGNMENT > switch to the uint32_t" to print-{ip,ip6}.c eleven months ago, but > he didn't want me to

Re: [patch] tcpdump print-atalk segfaults

2015-11-08 Thread Christian Weisgerber
Kevin Reay: > Fix multiple segfaults in the AppleTalk printer when a packet structs > extend past the actual captured length. While you are there... In my tree, I'm still lugging along the patch below. This is strictly equivalent to mikeb@'s change "Catch up with the BPF_ALIGNMENT switch to the

[patch] tcpdump print-atalk segfaults

2015-11-08 Thread Kevin Reay
Fix multiple segfaults in the AppleTalk printer when a packet structs extend past the actual captured length. Also add "const" to a struct cast to maintain consistency. Other issues to be addressed in future patches. Index: print-atalk.c ===