Re: [patch] mg: fix overflow on vteeol()

2017-07-06 Thread Florian Obser
Hi Ingo, thanks for your detailed analysis, makes sense to me OK florian@ Apologies to Hiltjo for slacking on this. I looked at it multiple times but couldn't make any progress on it. Florian On Thu, Jul 06, 2017 at 04:08:09PM +0200, Ingo Schwarze wrote: > Hi, > > Hiltjo Posthuma wrote on Sun,

Re: [patch] mg: fix overflow on vteeol()

2017-07-06 Thread Ingo Schwarze
Hi, Hiltjo Posthuma wrote on Sun, Jun 18, 2017 at 03:04:31PM +0200: > mg crashes with certain (unicode) characters and moving the cursor to the > end of the line. Even though i failed to reproduce the crash, even with MALLOC_OPTIONS=S, i see how it may happen. Your analysis looks at the right f

Re: [patch] mg: fix overflow on vteeol() (resend/bump)

2017-07-05 Thread Hiltjo Posthuma
On Sat, Jun 24, 2017 at 02:45:44PM +0200, Hiltjo Posthuma wrote: > On Sun, Jun 18, 2017 at 03:04:31PM +0200, Hiltjo Posthuma wrote: > > Hey, > > > > This is a resend/bump of a patch about a month ago, can it get applied? > > > > Original message below: > > > > > > mg crashes with certain (unico

Re: [patch] mg: fix overflow on vteeol() (resend/bump)

2017-06-24 Thread Hiltjo Posthuma
On Sun, Jun 18, 2017 at 03:04:31PM +0200, Hiltjo Posthuma wrote: > Hey, > > This is a resend/bump of a patch about a month ago, can it get applied? > > Original message below: > > > mg crashes with certain (unicode) characters and moving the cursor to the > end of the line. > > The characters

[patch] mg: fix overflow on vteeol() (resend/bump)

2017-06-18 Thread Hiltjo Posthuma
Hey, This is a resend/bump of a patch about a month ago, can it get applied? Original message below: mg crashes with certain (unicode) characters and moving the cursor to the end of the line. The characters are printed to the screen as \nnn in vtpute() and vtcol is updated, however vteeol() wi

Re: [patch] mg: fix overflow on vteeol()

2017-05-26 Thread Hiltjo Posthuma
On Fri, May 12, 2017 at 12:01:52PM +0200, Hiltjo Posthuma wrote: > On Sun, May 07, 2017 at 05:31:26PM +0200, Hiltjo Posthuma wrote: > > Hey, > > > > mg crashes with certain (unicode) characters and moving the cursor to the > > end of the line. > > > > The characters are printed to the screen as \

Re: [patch] mg: fix overflow on vteeol()

2017-05-12 Thread Hiltjo Posthuma
On Sun, May 07, 2017 at 05:31:26PM +0200, Hiltjo Posthuma wrote: > Hey, > > mg crashes with certain (unicode) characters and moving the cursor to the > end of the line. > > The characters are printed to the screen as \nnn in vtpute() and vtcol is > updated, however vteeol() will write beyond the

Re: [patch] mg: fix overflow on vteeol()

2017-05-07 Thread S. Gilles
On 2017-05-07T17:31:26+0200, Hiltjo Posthuma wrote: > Hey, > > mg crashes with certain (unicode) characters and moving the cursor to the > end of the line. > > The characters are printed to the screen as \nnn in vtpute() and vtcol is > updated, however vteeol() will write beyond the buffer. Abou

[patch] mg: fix overflow on vteeol()

2017-05-07 Thread Hiltjo Posthuma
Hey, mg crashes with certain (unicode) characters and moving the cursor to the end of the line. The characters are printed to the screen as \nnn in vtpute() and vtcol is updated, however vteeol() will write beyond the buffer. A test file contains the data: —— It is printed to t