Re: [patch] libssl/src/ssl/ssl_rsa.c

2014-05-08 Thread Ted Unangst
On Thu, May 08, 2014 at 22:39, Theo de Raadt wrote: > Your diff does not solve a problem. Specifically, I don't think it's worth changing such code back or forth either way, but using an extra variable to store the return value from a function can make debugging easier. I may want to look at the r

Re: [patch] libssl/src/ssl/ssl_rsa.c

2014-05-08 Thread Theo de Raadt
Your diff does not solve a problem. > In case this is considered important enough... > Remove unused "ret" from SSL_use_PrivateKey(). > > - Michael > > > Index: ssl_rsa.c > === > RCS file: /cvs/src/lib/libssl/src/ssl/ssl_rsa.c,v >

[patch] libssl/src/ssl/ssl_rsa.c

2014-05-08 Thread Michael W. Bombardieri
Hi tech@, In case this is considered important enough... Remove unused "ret" from SSL_use_PrivateKey(). - Michael Index: ssl_rsa.c === RCS file: /cvs/src/lib/libssl/src/ssl/ssl_rsa.c,v retrieving revision 1.11 diff -u -r1.11 ssl_rs