Re: [patch] if-free cleanup in sys/arch

2015-09-15 Thread Rafael Neves
On Tue, Sep 15, 2015 at 8:37 PM, Ted Unangst wrote: > Miod Vallat wrote: > > > Hi, > > > > > > Here a first sets of "if(x) free(x)" cleanup in sys/arch/ > > > > > > This patch contains only trivial if(x) removal. The size argument in > > > free is keep untouched (because it is already setted, or

Re: [patch] if-free cleanup in sys/arch

2015-09-15 Thread Miod Vallat
> > The arch/*/stand use a free() implementation which does not accept NULL > > pointers (see sys/lib/libsa/alloc.c). > > But we're going to fix that too, right? Yes. Developers those days are expecting free(NULL) to work, and as long as it's easy to achieve, there is no reason to deprive them fr

Re: [patch] if-free cleanup in sys/arch

2015-09-15 Thread Ted Unangst
Miod Vallat wrote: > > Hi, > > > > Here a first sets of "if(x) free(x)" cleanup in sys/arch/ > > > > This patch contains only trivial if(x) removal. The size argument in > > free is keep untouched (because it is already setted, or because it > > makes sens to keep it to 0). > > > > Comments ? OK

Re: [patch] if-free cleanup in sys/arch

2015-09-15 Thread Michael McConville
Miod Vallat wrote: > > Hi, > > > > Here a first sets of "if(x) free(x)" cleanup in sys/arch/ > > > > This patch contains only trivial if(x) removal. The size argument in > > free is keep untouched (because it is already setted, or because it > > makes sens to keep it to 0). > > > > Comments ? OK

Re: [patch] if-free cleanup in sys/arch

2015-09-15 Thread Miod Vallat
> Hi, > > Here a first sets of "if(x) free(x)" cleanup in sys/arch/ > > This patch contains only trivial if(x) removal. The size argument in > free is keep untouched (because it is already setted, or because it > makes sens to keep it to 0). > > Comments ? OK ? The arch/*/stand use a free() imp

[patch] if-free cleanup in sys/arch

2015-09-14 Thread Sebastien Marie
Hi, Here a first sets of "if(x) free(x)" cleanup in sys/arch/ This patch contains only trivial if(x) removal. The size argument in free is keep untouched (because it is already setted, or because it makes sens to keep it to 0). Comments ? OK ? -- Sebastien Marie Index: b/sys/arch/amd64/stand/l