Re: [patch] Use snprintf to implement concat in etc.c

Hi Philip, Thanks for your comments! On 6/9/2018 12:35 PM, Philip Guenther wrote: > On Thu, Jun 7, 2018 at 12:34 AM Nan Xiao > wrote: > > I think maybe one snprintf is more efficient and concise. Sorry if I am > wrong, thanks! > > > Seems unlikely.  More p

Re: [patch] Use snprintf to implement concat in etc.c

On Thu, Jun 7, 2018 at 12:34 AM Nan Xiao wrote: > I think maybe one snprintf is more efficient and concise. Sorry if I am > wrong, thanks! > Seems unlikely. More productive would be to go up a level and look at whether concat() is carrying its weight as an abstraction. One of the calls is comp

[patch] Use snprintf to implement concat in etc.c

HI tech@, I think maybe one snprintf is more efficient and concise. Sorry if I am wrong, thanks! Index: etc.c === RCS file: /cvs/src/libexec/ld.so/ldconfig/etc.c,v retrieving revision 1.7 diff -u -p -r1.7 etc.c --- etc.c 12 May