Re: [patch] Avoid system(3) in ikectl

2017-06-12 Thread Matthew Martin
On Thu, Jun 08, 2017 at 10:39:08PM +1000, Jonathan Gray wrote: > This would be simpler if the 'run' style function just took a NULL > terminated array. Closer to how other things work and could then > be passed directly to an exec call. Like so? Not sure if the indentation is correct or if it's

Re: [patch] Avoid system(3) in ikectl

2017-06-08 Thread Jonathan Gray
On Fri, May 19, 2017 at 12:32:16AM -0500, Matthew Martin wrote: > ikectl errors in a number of situations where shell special characters > are used. For example: > > % doas ikectl ca test create password \' > [...] > subject=/C=DE/ST=Lower Saxony/L=Hanover/O=OpenBSD/OU=iked/CN=VPN > CA/emailAddre

Re: [patch] Avoid system(3) in ikectl

2017-05-22 Thread Jonathan Gray
On Fri, May 19, 2017 at 09:56:14AM +0100, Stuart Henderson wrote: > On 2017/05/19 00:32, Matthew Martin wrote: > > ikectl errors in a number of situations where shell special characters > > are used. For example: > > > > % doas ikectl ca test create password \' > > [...] > > subject=/C=DE/ST=Lower

Re: [patch] Avoid system(3) in ikectl

2017-05-19 Thread Stuart Henderson
On 2017/05/19 00:32, Matthew Martin wrote: > ikectl errors in a number of situations where shell special characters > are used. For example: > > % doas ikectl ca test create password \' > [...] > subject=/C=DE/ST=Lower Saxony/L=Hanover/O=OpenBSD/OU=iked/CN=VPN > CA/emailAddress=r...@openbsd.org >

[patch] Avoid system(3) in ikectl

2017-05-18 Thread Matthew Martin
ikectl errors in a number of situations where shell special characters are used. For example: % doas ikectl ca test create password \' [...] subject=/C=DE/ST=Lower Saxony/L=Hanover/O=OpenBSD/OU=iked/CN=VPN CA/emailAddress=r...@openbsd.org Getting Private key sh: no closing quote This is because