Re: [patch] Add kvm_close in mib_hrsystemprocs function

On Mon, Jun 04 2018, Gerhard Roth wrote: > On Thu, 31 May 2018 17:40:36 +0800 Nan Xiao wrote: >> Hi Gerhard, >> >> Thanks for your reply! >> >> Yes, if no "kvm_close(kd);", there will be resource (memory, file >> descriptor) leak. So hope you can commit it, thanks! >> >> >> On 5/30/2018 4:49

Re: [patch] Add kvm_close in mib_hrsystemprocs function

On Thu, 31 May 2018 17:40:36 +0800 Nan Xiao wrote: > Hi Gerhard, > > Thanks for your reply! > > Yes, if no "kvm_close(kd);", there will be resource (memory, file > descriptor) leak. So hope you can commit it, thanks! > > > On 5/30/2018 4:49 PM, Gerhard Roth wrote: > > On Wed, 30 May 2018 16:25

Re: [patch] Add kvm_close in mib_hrsystemprocs function

Hi Gerhard, Thanks for your reply! Yes, if no "kvm_close(kd);", there will be resource (memory, file descriptor) leak. So hope you can commit it, thanks! On 5/30/2018 4:49 PM, Gerhard Roth wrote: > On Wed, 30 May 2018 16:25:55 +0800 Nan Xiao wrote: >> Hi tech@, >> >> Maybe kvm_close is needed

Re: [patch] Add kvm_close in mib_hrsystemprocs function

On Wed, 30 May 2018 16:25:55 +0800 Nan Xiao wrote: > Hi tech@, > > Maybe kvm_close is needed if kvm_getprocs returns NULL here? Sorry if I > am wrong, thanks! > > Index: mib.c > === > RCS file: /cvs/src/usr.sbin/snmpd/mib.c,v > retr

[patch] Add kvm_close in mib_hrsystemprocs function

Hi tech@, Maybe kvm_close is needed if kvm_getprocs returns NULL here? Sorry if I am wrong, thanks! Index: mib.c === RCS file: /cvs/src/usr.sbin/snmpd/mib.c,v retrieving revision 1.87 diff -u -p -r1.87 mib.c --- mib.c 25 May 20