Re: [patch] Add error check for fchmod in ldconfig.c

2018-06-07 Thread Philip Guenther
On Thu, Jun 7, 2018 at 7:16 PM, Scott Cheloha wrote: > On Thu, Jun 07, 2018 at 03:31:16PM +0800, Nan Xiao wrote: > > Hi tech@, > > > > Maybe a error check of fchmod is necessary. [...] > ... > This patch is ok cheloha@ and I can commit this if someone else is ok with > it, but I'd really like to

Re: [patch] Add error check for fchmod in ldconfig.c

2018-06-07 Thread Scott Cheloha
On Thu, Jun 07, 2018 at 03:31:16PM +0800, Nan Xiao wrote: > Hi tech@, > > Maybe a error check of fchmod is necessary. [...] In that spot I think the only way fchmod can fail is with EIO. But, for sake of discussion, suppose it fails with EIO and then all the subsequent writes succeed and the EIO

[patch] Add error check for fchmod in ldconfig.c

2018-06-07 Thread Nan Xiao
Hi tech@, Maybe a error check of fchmod is necessary. Sorry if I am wrong, thanks! Index: ldconfig.c === RCS file: /cvs/src/libexec/ld.so/ldconfig/ldconfig.c,v retrieving revision 1.37 diff -u -p -r1.37 ldconfig.c --- ldconfig.c 26