Re: [Patch] pf refactoring

2015-08-17 Thread Martin Pieuchot
On 17/08/15(Mon) 13:38, Alexey Suslikov wrote: > Martin Pieuchot openbsd.org> writes: > > > On 17/08/15(Mon) 17:39, Richard Procter wrote: > > > Hi, > > > > > > This series of 29 small diffs slims pf.o by 2640 bytes and pf.c by > > > 113 non-comment lines. > > > > We generally discuss one diff

Re: [Patch] pf refactoring

2015-08-17 Thread Alexey Suslikov
Martin Pieuchot openbsd.org> writes: > On 17/08/15(Mon) 17:39, Richard Procter wrote: > > Hi, > > > > This series of 29 small diffs slims pf.o by 2640 bytes and pf.c by > > 113 non-comment lines. > > We generally discuss one diff per mail. It makes it easier for people > to comment and as you

Re: [Patch] pf refactoring

2015-08-17 Thread Martin Pieuchot
Hello Richard, On 17/08/15(Mon) 17:39, Richard Procter wrote: > Hi, > > This series of 29 small diffs slims pf.o by 2640 bytes and pf.c by > 113 non-comment lines. We generally discuss one diff per mail. It makes it easier for people to comment and as you can imagine deal with possible conflic

[Patch] pf refactoring

2015-08-16 Thread Richard Procter
Hi, This series of 29 small diffs slims pf.o by 2640 bytes and pf.c by 113 non-comment lines. pf_translate(), in particular, is now much shorter and clearer[0]. I've tested it by running on my home router (alix, i386, inet4) for a week or so without issue, and by profiling it under stress. I sa