Re: [PATCH 1/3] Check output of write() to stdout

2014-06-02 Thread Ted Unangst
On Mon, Jun 02, 2014 at 09:51, Brent Cook wrote: > Is something like this more to taste? Or maybe just a simple (void)write() > as in libc/time/zic.c ? I think maybe we want to save this one for later. If it's not immediately obvious what the correct fix is, move along to something where the corr

Re: [PATCH 1/3] Check output of write() to stdout

2014-06-02 Thread Brent Cook
> abort? are you insane? no no no no... Me IRL: http://cdn.memegenerator.net/instances/400x/37703326.jpg That’s the problem with swiss army knife programs; too many corner cases. I was thinking about why SIGPIPE exists and something like this: cat /dev/urandom | openssl s_server -quiet | cra

Re: [PATCH 1/3] Check output of write() to stdout

2014-06-02 Thread Bob Beck
abort? are you insane? no no no no... On Sun, Jun 1, 2014 at 8:28 PM, Brent Cook wrote: > Check for errors on write. Since SIGPIPE is ignored, play nicely with > pipelines by aborting on EPIPE. > --- > src/apps/s_server.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 1/3] Check output of write() to stdout

2014-06-01 Thread Theo de Raadt
This diff is very dissapointing. > Check for errors on write. Since SIGPIPE is ignored, play nicely with > pipelines by aborting on EPIPE. > --- > src/apps/s_server.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/apps/s_server.c b/src/apps/s_server.c > ind

[PATCH 1/3] Check output of write() to stdout

2014-06-01 Thread Brent Cook
Check for errors on write. Since SIGPIPE is ignored, play nicely with pipelines by aborting on EPIPE. --- src/apps/s_server.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/apps/s_server.c b/src/apps/s_server.c index 77384ec..836d46b 100644 --- a/src/apps/s_server.c