Re: [PATCH] src/usr.bin/ftp/fetch.c: free ressl_config

2014-09-12 Thread Ted Unangst
On Fri, Sep 12, 2014 at 09:39, Kent R. Spillner wrote: > On Fri, Sep 12, 2014 at 12:38:07AM -0700, Doug Hogan wrote: >> Hmm this doesn't look right to me. ressl_config is not allocated the >> same way as the other variables. The other variables such as ssl, >> sslhost, etc are local to that funct

Re: [PATCH] src/usr.bin/ftp/fetch.c: free ressl_config

2014-09-12 Thread Kent R. Spillner
On Fri, Sep 12, 2014 at 09:39:30AM -0500, Kent R. Spillner wrote: > Of course, you're right. Is there any reason why ressl_config must be > global? It's only used in url_get. It should be harmless to create a > new one each time as long as we always free it. > > Here's a diff for that: Forgot

Re: [PATCH] src/usr.bin/ftp/fetch.c: free ressl_config

2014-09-12 Thread Kent R. Spillner
On Fri, Sep 12, 2014 at 12:38:07AM -0700, Doug Hogan wrote: > Hmm this doesn't look right to me. ressl_config is not allocated the > same way as the other variables. The other variables such as ssl, > sslhost, etc are local to that function and allocated there. > ressl_config is a global and only

Re: [PATCH] src/usr.bin/ftp/fetch.c: free ressl_config

2014-09-12 Thread Doug Hogan
On Thu, Sep 11, 2014 at 11:05:02PM -0500, Kent R. Spillner wrote: > While reviewing tedu@'s libressl config cleanup diffs I noticed we're > not explicitly freeing ressl_config in ftp(1). ... > Index: fetch.c > === ... > if (ssl !

[PATCH] src/usr.bin/ftp/fetch.c: free ressl_config

2014-09-11 Thread Kent R. Spillner
While reviewing tedu@'s libressl config cleanup diffs I noticed we're not explicitly freeing ressl_config in ftp(1). Ok? Index: fetch.c === RCS file: /work/cvsroot/src/usr.bin/ftp/fetch.c,v retrieving revision 1.129 diff -p -u -r1.12