Re: [PATCH] remove useless casts in if_gre.c

2012-12-13 Thread sickmind
On 03:07 Thu 13 Dec , Rafael Ferreira Neves wrote: > Hello, > > I think that the original code is correct. The definition of ip_output > function says that the first argument is a pointer to an mbuf, but the > other are variadic. In this case style(9) states that (type *)NULL should > be used.

Re: [PATCH] remove useless casts in if_gre.c

2012-12-12 Thread Rafael Ferreira Neves
Hello, I think that the original code is correct. The definition of ip_output function says that the first argument is a pointer to an mbuf, but the other are variadic. In this case style(9) states that (type *)NULL should be used. Regards Rafael On Thu, Dec 13, 2012 at 2:11 AM, Michael W. Bomba

[PATCH] remove useless casts in if_gre.c

2012-12-12 Thread Michael W. Bombardieri
Hi, I have a small patch for if_gre.c... NULL is already defined as ((void *)0), so we don't need to cast it to void*. No binary change on amd64. Does this look OK? - Michael Index: if_gre.c === RCS file: /cvs/src/sys/net/if_gre.