Re: [PATCH] remove macros only used once

Once we have that done we might at an opportune time ask our intrepid ports builders to find out for us who is using that little gem, and we could *conisder* removing it then if we're certain nobody has walked in looking like an Oatmeal-drawn dog and said "Oh boy Oh boy.. ANOTHER malloc wrapper I c

Re: [PATCH] remove macros only used once

I hate the amount of useless garbage API this thing exposes externally, that we then have to wonder "WTF out there might use it..".. G. Dirk the right way to do this is leave the macros for now (ick) but change the internals of all our stuff to use intrinsics without the use of the macros. We

Re: [PATCH] remove macros only used once

Note that asn1_mac.h is installed... You're right, I found it referenced at least here: http://opensource.apple.com/source/OpenSSL/OpenSSL-5/openssl/crypto/asn1/p5_pbev2.c erdgeist

Re: [PATCH] remove macros only used once

Bob Beck writes: > I will be a minute reading this. The comment from the context at the > bottom of the diff has > me laughing and crying again... Note that asn1_mac.h is installed... > On Tue, Apr 22, 2014 at 5:43 PM, Dirk Engling wrote: >> remove M_ASN1_New_Malloc, M_ASN1_New, M_ASN1_New_Err

Re: [PATCH] remove macros only used once

I will be a minute reading this. The comment from the context at the bottom of the diff has me laughing and crying again... On Tue, Apr 22, 2014 at 5:43 PM, Dirk Engling wrote: > remove M_ASN1_New_Malloc, M_ASN1_New, M_ASN1_New_Error marcos, they hide > a malloc and are only used once > > > Inde

[PATCH] remove macros only used once

remove M_ASN1_New_Malloc, M_ASN1_New, M_ASN1_New_Error marcos, they hide a malloc and are only used once Index: x_pkey.c === RCS file: /cvs/src/lib/libssl/src/crypto/asn1/x_pkey.c,v retrieving revision 1.10 diff -u -r1.10 x_pkey.c --