Re: [PATCH] mfs improvements

2014-11-15 Thread bytevolcano
On Sat, 15 Nov 2014 19:27:11 -0700 (MST) Theo de Raadt wrote: > Nope. That is unsuitable use of issetugid. This is not a setuid > program. Revised diff below omits that change then. Index: sbin/newfs/newfs.c === RCS file: /cvs/

Re: [PATCH] mfs improvements

2014-11-15 Thread Theo de Raadt
Nope. That is unsuitable use of issetugid. This is not a setuid program. > 2. Call and check issetugid() to ensure the information from getenv() > is safe to use. If not, default to _PATH_TMP. > > >Index: sbin/newfs/newfs.c >=== >RC

[PATCH] mfs improvements

2014-11-15 Thread bytevolcano
Based on feedback from others on this list while creating a tmpfs patch over a month ago, I have fixed some issues with mount_mfs: 1. Print out an error message if the template directory path is too long rather than just silently trucating it. 2. Call and check issetugid() to ensure the inform