Re: [PATCH] frame length validation for USB ethernet adapters

2011-03-21 Thread Loganaden Velvindron
Hi, I updated the diff for axe(4) based on what Laurent sent me. He says the patch breaks his axe(4). I also added a comment to explain why it's done, in areas where there's a status bit called RX_STATUS. This is based on an issue I encountered with udav(4), wherein despite having a valid status

Re: [PATCH] frame length validation for USB ethernet adapters

2011-03-20 Thread Fred Crowson
On 03/19/11 18:01, Loganaden Velvindron wrote: Hi, I'm uploading the new diffs for this. It concerns axe(4), aue(4), cdce(4), cue(4), kue(4), mos(4) and url(4). Of these, axe(4) is the most tricky, and I'd appreciate testing on all vaariants of axe(4). Please test both small and large packets (

Re: [PATCH] frame length validation for USB ethernet adapters

2011-03-19 Thread Loganaden Velvindron
Miod pointed out a wrong variable used for axe(4) diff. Thanks. Index: if_axe.c === RCS file: /cvs/src/sys/dev/usb/if_axe.c,v retrieving revision 1.105 diff -u -p -r1.105 if_axe.c --- if_axe.c25 Jan 2011 20:03:35 - 1.105

Re: [PATCH] frame length validation for USB ethernet adapters

2011-03-19 Thread Miod Vallat
> Index: src/sys/dev/usb/if_axe.c > === > RCS file: /cvs/src/sys/dev/usb/if_axe.c,v > retrieving revision 1.105 > diff -u -p -r1.105 if_axe.c > --- src/sys/dev/usb/if_axe.c 25 Jan 2011 20:03:35 - 1.105 > +++ src/sys/dev/usb/i

Re: [PATCH] frame length validation for USB ethernet adapters

2011-03-19 Thread Loganaden Velvindron
Hi, I'm uploading the new diffs for this. It concerns axe(4), aue(4), cdce(4), cue(4), kue(4), mos(4) and url(4). Of these, axe(4) is the most tricky, and I'd appreciate testing on all vaariants of axe(4). Please test both small and large packets (NFS and SCP). As usual, feedback is most welcome

Re: [PATCH] frame length validation for USB ethernet adapters

2011-03-16 Thread Loganaden Velvindron
The broken udav(4) diff is my fault. I didn't test with NFS and large file transfers when jsg@ sent me his diff (privately). He trusted my feedback and that's how it was committed. Can we move on now ? //Logan C-x-C-c

Re: [PATCH] frame length validation for USB ethernet adapters

2011-03-16 Thread Loganaden Velvindron
Hi Kiki, Can you send us a trace & dmesg ? //Logan C-x-C-c

Re: [PATCH] frame length validation for USB ethernet adapters

2011-03-16 Thread Matthias Kilian
Hi, On Wed, Mar 16, 2011 at 04:58:19PM -0400, Loganaden Velvindron wrote: > After my experience with udav(4), I took a look at other USB > adapters. The diff makes all of them more consistent by checking > the frame length returned and validating it. > > Since I don't own any of those adapters

[PATCH] frame length validation for USB ethernet adapters

2011-03-16 Thread Loganaden Velvindron
After my experience with udav(4), I took a look at other USB adapters. The diff makes all of them more consistent by checking the frame length returned and validating it. Since I don't own any of those adapters, I must rely on you people to test them. The diff is wrong unless successful report