Re: [PATCH] fix overflow handling in dd(1)

2014-09-14 Thread Ingo Schwarze
Hi, Todd C. Miller wrote on Fri, Sep 12, 2014 at 09:23:31AM -0600: > On Thu, 11 Sep 2014 22:03:04 -0700, William Orr wrote: >> I'm resubmitting this patch since the source tree was locked last time I >> submitted. Any thoughts? > I think we've discussed this one to death already. It looks fine

Re: [PATCH] fix overflow handling in dd(1)

2014-09-12 Thread Todd C. Miller
On Thu, 11 Sep 2014 22:03:04 -0700, William Orr wrote: > I'm resubmitting this patch since the source tree was locked last time I > submitted. Any thoughts? I think we've discussed this one to death already. It looks fine to me. - todd

[PATCH] fix overflow handling in dd(1)

2014-09-11 Thread William Orr
Hey, I'm resubmitting this patch since the source tree was locked last time I submitted. Any thoughts? Thanks, William Orr Index: bin/dd/args.c === RCS file: /cvs/src/bin/dd/args.c,v retrieving revision 1.25 diff -u -b -w -p -r1.25

Re: [PATCH] fix overflow handling in dd(1)

2014-08-04 Thread William Orr
Hey, Sorry to bring this up again, but are there any other changes that need to be made to this patch? I've fixed all of the major complaints. Thanks, William Orr On 07/13/2014 02:19 AM, William Orr wrote: > Here is the latest diff with the bullshit removed and the loop replaced > with strchr. >

Re: [PATCH] fix overflow handling in dd(1)

2014-07-13 Thread William Orr
Here is the latest diff with the bullshit removed and the loop replaced with strchr. Index: bin/dd/args.c === RCS file: /cvs/src/bin/dd/args.c,v retrieving revision 1.25 diff -u -b -w -p -r1.25 args.c --- bin/dd/args.c 21 May

Re: [PATCH] fix overflow handling in dd(1)

2014-07-13 Thread William Orr
Sorry, the libssl patch was unintentional. I forgot to cvs up -C that one. On 7/13/2014 2:05 AM, Ted Unangst wrote: On Sun, Jul 13, 2014 at 01:52, William Orr wrote: Hey, I sent a patch similar to this almost a month ago with no response. Feedback? Interest? Yes. - num = strtoul(val,

Re: [PATCH] fix overflow handling in dd(1)

2014-07-13 Thread Ted Unangst
On Sun, Jul 13, 2014 at 01:52, William Orr wrote: > Hey, > > I sent a patch similar to this almost a month ago with no response. > > Feedback? Interest? Yes. > > - num = strtoul(val, &expr, 0); > - if (num == SIZE_T_MAX) /* Overflow. */ > + while (isspace(vp[0])) >

[PATCH] fix overflow handling in dd(1)

2014-07-13 Thread William Orr
Hey, I sent a patch similar to this almost a month ago with no response. Feedback? Interest? This patch fixes the following: - Takes negative values - When SIZE_T_MAX was passed, returns undefined error Index: bin/dd/args.c === RC