Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-09 Thread Ted Unangst
On Fri, May 09, 2014 at 18:50, Fritjof Bornebusch wrote: > But if you like OpenRCS as it is and don't want to get any diffs unless > security fixes, then just say it. > Or if you work on other stuff and you don't have time for that, then just > say it. Personally, I don't much like to see diffs "f

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-09 Thread Fritjof Bornebusch
On Fri, May 09, 2014 at 06:01:52PM +0200, J??r??mie Courr??ges-Anglas wrote: > Fritjof Bornebusch writes: > > > Hi tech, > > Hi, > > > if I compile rcs, gcc prints a few warnings like this: > > - comparison between signed and unsigned > > - signed and unsigned type in conditional expression > >

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-09 Thread Fritjof Bornebusch
On Fri, May 09, 2014 at 12:35:11PM -0400, Kenneth Westerback wrote: > On 9 May 2014 11:47, Kenneth Westerback wrote: > > On 9 May 2014 11:41, Fritjof Bornebusch wrote: > >> On Wed, May 07, 2014 at 08:59:03PM +0200, Fritjof Bornebusch wrote: > >>> On Wed, May 07, 2014 at 08:05:35PM +0200, J??r??mi

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-09 Thread Jérémie Courrèges-Anglas
Fritjof Bornebusch writes: > Hi tech, Hi, > if I compile rcs, gcc prints a few warnings like this: > - comparison between signed and unsigned > - signed and unsigned type in conditional expression > > I'm not quite sure if the typecasts are at the correct place, but these diffs > removes the w

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-09 Thread Kenneth Westerback
On 9 May 2014 11:47, Kenneth Westerback wrote: > On 9 May 2014 11:41, Fritjof Bornebusch wrote: >> On Wed, May 07, 2014 at 08:59:03PM +0200, Fritjof Bornebusch wrote: >>> On Wed, May 07, 2014 at 08:05:35PM +0200, J??r??mie Courr??ges-Anglas wrote: >>> > Fritjof Bornebusch writes: >>> > >>> > [..

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-09 Thread Kenneth Westerback
On 9 May 2014 11:41, Fritjof Bornebusch wrote: > On Wed, May 07, 2014 at 08:59:03PM +0200, Fritjof Bornebusch wrote: >> On Wed, May 07, 2014 at 08:05:35PM +0200, J??r??mie Courr??ges-Anglas wrote: >> > Fritjof Bornebusch writes: >> > >> > [...] >> > >> > > Does no one want to check the diff and g

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-09 Thread Fritjof Bornebusch
On Wed, May 07, 2014 at 08:59:03PM +0200, Fritjof Bornebusch wrote: > On Wed, May 07, 2014 at 08:05:35PM +0200, J??r??mie Courr??ges-Anglas wrote: > > Fritjof Bornebusch writes: > > > > [...] > > > > > Does no one want to check the diff and give me some feedback? > > > > Regardless of the conte

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-07 Thread Fritjof Bornebusch
On Wed, May 07, 2014 at 08:05:35PM +0200, J??r??mie Courr??ges-Anglas wrote: > Fritjof Bornebusch writes: > > [...] > > > Does no one want to check the diff and give me some feedback? > > Regardless of the content of your diff, the date of your mail was: > > Date: Tue, 6 May 2014 22:57:57 +0

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-07 Thread Jérémie Courrèges-Anglas
Fritjof Bornebusch writes: [...] > Does no one want to check the diff and give me some feedback? Regardless of the content of your diff, the date of your mail was: Date: Tue, 6 May 2014 22:57:57 +0200 I doubt there are developers that are paid full-time to improve rcs, please be more patien

Re: [PATCH] comparison between signed and unsigned in rcs

2014-05-07 Thread Fritjof Bornebusch
On Tue, May 06, 2014 at 10:57:57PM +0200, Fritjof Bornebusch wrote: > Hi tech, > > if I compile rcs, gcc prints a few warnings like this: > - comparison between signed and unsigned > - signed and unsigned type in conditional expression > > I'm not quite sure if the typecasts are at the correct pl

[PATCH] comparison between signed and unsigned in rcs

2014-05-06 Thread Fritjof Bornebusch
Hi tech, if I compile rcs, gcc prints a few warnings like this: - comparison between signed and unsigned - signed and unsigned type in conditional expression I'm not quite sure if the typecasts are at the correct place, but these diffs removes the warnings. fritjof Index: buf.c ==