Re: [PATCH] adds -t timeout to slowcgi

2022-08-06 Thread Omar Polo
after the other thread on tech@ reminded me this is still pending, i took a look, tested and committed it with some minor tweaks. Thanks! Florian Obser wrote: > On 2022-06-10 04:27 -07, Alfred Morgan wrote: > > Index: slowcgi.8 > > ===

Re: [PATCH] adds -t timeout to slowcgi

2022-06-11 Thread Florian Obser
On 2022-06-10 04:27 -07, Alfred Morgan wrote: >> The connection to upstream (e.g. httpd) is closed so the client gets a 500 >> error. > > Hmm, this isn't my experience. Possibly a slowcgi bug? My clients were > getting no response, e.g.: > curl: (52) Empty reply from server > >> But the script ke

Re: [PATCH] adds -t timeout to slowcgi

2022-06-10 Thread Alfred Morgan
I continued reading the CGI spec and a timeout is specifically mentioned in section 6.1 Response Handling: "The server MAY implement a timeout period within which data must be received from the script. If a server implementation defines such a timeout and receives no data from a script withi

Re: [PATCH] adds -t timeout to slowcgi

2022-06-10 Thread Alfred Morgan
> The connection to upstream (e.g. httpd) is closed so the client gets a 500 > error. Hmm, this isn't my experience. Possibly a slowcgi bug? My clients were getting no response, e.g.: curl: (52) Empty reply from server > But the script keeps running. Ah, I see now that the process is left to ru

Re: [PATCH] adds -t timeout to slowcgi

2022-06-09 Thread Florian Obser
On 2022-06-09 01:36 -07, Alfred Morgan wrote: > I think this got missed on misc@ when I posted on 5/24. I'm now > reposting here in tech@ with the [PATCH] subject tag. > > Index: usr.sbin/slowcgi/slowcgi.8 > === > RCS file: /cvs/src/u

Re: [PATCH] adds -t timeout to slowcgi

2022-06-09 Thread Stuart Henderson
On 2022/06/09 01:36, Alfred Morgan wrote: > I think this got missed on misc@ when I posted on 5/24. I'm now Diffs are definitely likely to get missed on misc@ > reposting here in tech@ with the [PATCH] subject tag. This diff is mangled, tabs have been converted to spaces and it doesn't apply wit

[PATCH] adds -t timeout to slowcgi

2022-06-09 Thread Alfred Morgan
I think this got missed on misc@ when I posted on 5/24. I'm now reposting here in tech@ with the [PATCH] subject tag. Index: usr.sbin/slowcgi/slowcgi.8 === RCS file: /cvs/src/usr.sbin/slowcgi/slowcgi.8,v retrieving revision 1.16 diff