Re: [PATCH] add filter by host functionality to syslogd

2013-05-23 Thread Ted Unangst
On Thu, May 23, 2013 at 19:55, Gregory Edigarov wrote: >> That's just a string compare. The remote host can send any string it >> wants. >> > yes, it doesn't do any host resolution itself and there is no need in this, > because syslogd already does this. (the resolution happens in main cycle, > na

Re: [PATCH] add filter by host functionality to syslogd

2013-05-23 Thread Gregory Edigarov
On 05/23/2013 07:20 PM, Ted Unangst wrote: On Thu, May 23, 2013 at 12:57, Gregory Edigarov wrote: On 05/22/2013 06:39 PM, Ted Unangst wrote: On Wed, May 22, 2013 at 12:06, Gregory Edigarov wrote: works for me, with only one limitation: now only for resolvable hosts, i.e one cannot have +192.1

Re: [PATCH] add filter by host functionality to syslogd

2013-05-23 Thread Ted Unangst
On Thu, May 23, 2013 at 12:57, Gregory Edigarov wrote: > On 05/22/2013 06:39 PM, Ted Unangst wrote: >> On Wed, May 22, 2013 at 12:06, Gregory Edigarov wrote: >>> >>> works for me, with only one limitation: now only for resolvable hosts, i.e >>> one cannot have >>> +192.168.2.1 >>> * /some

Re: [PATCH] add filter by host functionality to syslogd

2013-05-23 Thread Theo de Raadt
> no, it is really a resolvable hosts. It is unsafe.

Re: [PATCH] add filter by host functionality to syslogd

2013-05-23 Thread Gregory Edigarov
On 05/22/2013 06:39 PM, Ted Unangst wrote: On Wed, May 22, 2013 at 12:06, Gregory Edigarov wrote: works for me, with only one limitation: now only for resolvable hosts, i.e one cannot have +192.168.2.1 * /some/file Looking at the diff, I think it's not resolvable hosts, but what

Re: [PATCH] add filter by host functionality to syslogd

2013-05-22 Thread Ted Unangst
On Wed, May 22, 2013 at 12:06, Gregory Edigarov wrote: > > works for me, with only one limitation: now only for resolvable hosts, i.e > one cannot have > +192.168.2.1 > * /some/file Looking at the diff, I think it's not resolvable hosts, but whatever hostname the sending machine decid

[PATCH] add filter by host functionality to syslogd

2013-05-22 Thread Gregory Edigarov
Hi, the following diff adds filter by host function to syslogd like: +host * /var/log/host or +host2 mail.* /var/log/host2.mail etc. works for me, with only one limitation: now only for resolvable hosts, i.e one cannot have +192.168.2.1 * /some/file Wit