Re: [PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-11 Thread Carlos Cardenas
On 10/10/17 23:31, Claudio Jeker wrote: > On Tue, Oct 10, 2017 at 10:52:42PM -0700, Mike Larkin wrote: >> On Wed, Oct 11, 2017 at 06:46:22AM +0200, Claudio Jeker wrote: >>> On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote: Destroy switch on `vmctl reload` to allow SIOCBRDGADD to

Re: [PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-10 Thread Claudio Jeker
On Tue, Oct 10, 2017 at 10:52:42PM -0700, Mike Larkin wrote: > On Wed, Oct 11, 2017 at 06:46:22AM +0200, Claudio Jeker wrote: > > On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote: > > > Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed > > > when creating new bridge an

Re: [PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-10 Thread Mike Larkin
On Wed, Oct 11, 2017 at 06:46:22AM +0200, Claudio Jeker wrote: > On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote: > > Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed > > when creating new bridge and attaching interfaces to it. > > > > Comments? Ok? > > I don't thi

Re: [PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-10 Thread Claudio Jeker
On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote: > Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed > when creating new bridge and attaching interfaces to it. > > Comments? Ok? I don't think it is a good idea to destroy and recreate bridge interfaces on every reloa

[PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-10 Thread Carlos Cardenas
Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed when creating new bridge and attaching interfaces to it. Comments? Ok? diff --git usr.sbin/vmd/priv.c usr.sbin/vmd/priv.c index ef42549d105..0190c049837 100644 --- usr.sbin/vmd/priv.c +++ usr.sbin/vmd/priv.c @@ -88,6 +88,7 @@ priv_d