On Sat, 09 Jan 2021 14:39:53 -0800
Greg Steuck wrote:
> Thanks for the reviews!
>
> Marcus Glocker writes:
>
> > On Sat, 9 Jan 2021 22:09:06 +0100
> > Marcus Glocker wrote:
> > If you could fix the switch() indentation in a separate commit (as
> > you already mentioned in one of your previous
On Sat, 09 Jan 2021 14:39:53 -0800, Greg Steuck wrote:
> How's this instead? OK?
>
> Tested with the usual diff of before/after sysctl outputs and a random
> sysctl -w poke.
>
> Subject: [PATCH] Split hierarchical calls into kern_sysctl_dirs
>
> Removed a rash of +/-1 and made both functions short
Thanks for the reviews!
Marcus Glocker writes:
> On Sat, 9 Jan 2021 22:09:06 +0100
> Marcus Glocker wrote:
> If you could fix the switch() indentation in a separate commit (as you
> already mentioned in one of your previous e-mails), that would be nice.
How's this instead? OK?
Tested with the
On Sat, 9 Jan 2021 22:09:06 +0100
Marcus Glocker wrote:
> On Sat, 09 Jan 2021 13:06:36 -0800
> Greg Steuck wrote:
>
> > Thanks Todd for reviewing these boring patches!
> >
> > Todd C. Miller writes:
> >
> > > Updated diff looks good to me. OK millert@ but it would be good
> > > to get fee
On Sat, 09 Jan 2021 13:06:36 -0800
Greg Steuck wrote:
> Thanks Todd for reviewing these boring patches!
>
> Todd C. Miller writes:
>
> > Updated diff looks good to me. OK millert@ but it would be good
> > to get feedback from Marcus too.
>
> Sure thing, I'll wait till tomorrow then?
>
> T
Thanks Todd for reviewing these boring patches!
Todd C. Miller writes:
> Updated diff looks good to me. OK millert@ but it would be good
> to get feedback from Marcus too.
Sure thing, I'll wait till tomorrow then?
Thanks
Greg
On Mon, 28 Dec 2020 22:00:55 -0800, Greg Steuck wrote:
> Here's an updated version to account from an intervening change since I
> posted this first.
Updated diff looks good to me. OK millert@ but it would be good
to get feedback from Marcus too.
- todd
On Sun, 20 Dec 2020 15:52:07 -0800, Greg Steuck wrote:
> I tested this by diff'ing sysctl output before/after on amd64. Since
> there's a bunch of ifdef'ness I verified RAMDISK still builds.
>
> I deliberately didn't fix the indentation to keep this diff a pure line
> motion (would run over 80 cha
either fix that it in
> a separate commit or in this one before submitting.
>
> OK?
Here's an updated version to account from an intervening change since I
posted this first.
Marcus, since my change conflicted with yours, maybe you could review?
Thanks
Greg
Subject: [PATCH] Red
a separate commit or in this one before submitting.
OK?
Subject: [PATCH] Reduce case duplication in kern_sysctl
This changes amd64 GENERIC.MP .text size of kern_sysctl.o from 6440 to 6400.
Surprisingly, RAMDISK grows from 1645 to 1678.
---
sys/kern/kern_sysctl.c | 180 ++--
10 matches
Mail list logo
