Re: [PATCH] OpenSSH: auth.c

2012-12-14 Thread Maxime Villard
Le 14/12/2012 06:27, Darren Tucker a écrit : > On Thu, Dec 13, 2012 at 07:31:46PM +0100, Maxime Villard wrote: >> > Hi, >> > I was looking at some openssh code when I spotted a mistake > applied, thanks. Another trivial patch. Make a more detailed error message. Or, we should use strlcpy(). Ok ?

Re: [PATCH] OpenSSH: auth.c

2012-12-13 Thread Darren Tucker
On Thu, Dec 13, 2012 at 07:31:46PM +0100, Maxime Villard wrote: > Hi, > I was looking at some openssh code when I spotted a mistake applied, thanks. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experi

[PATCH] OpenSSH: auth.c

2012-12-13 Thread Maxime Villard
Hi, I was looking at some openssh code when I spotted a mistake in a function from auth.c: static int secure_filename(FILE *f, const char *file, struct passwd *pw, char *err, size_t errlen) { char buf[MAXPATHLEN]; struct stat st; /* check the open file to avoid races