Re: [PATCH] Better overflow handling in rcstime.c

2014-08-16 Thread Fritjof Bornebusch
On Wed, Jul 30, 2014 at 10:19:19PM +0200, Fritjof Bornebusch wrote: Ping? > Hi tech, > > remove the atoi calls, in order to avoid overflows. > > fritjof > > > Index: rcstime.c > === > RCS file: /cvs/src/usr.bin/rcs/rcstime.c,v > re

Re: [PATCH] Better overflow handling in rcstime.c

2014-08-03 Thread Dimitris Papastamos
On Sat, Aug 02, 2014 at 11:07:30PM +0200, Fritjof Bornebusch wrote: > On Wed, Jul 30, 2014 at 09:26:54PM +0100, Dimitris Papastamos wrote: > > On Wed, Jul 30, 2014 at 10:19:19PM +0200, Fritjof Bornebusch wrote: > > > + tzone = (int)strtonum(h, -23, 23, &errstr); > > > > The explicit cast i

Re: [PATCH] Better overflow handling in rcstime.c

2014-08-02 Thread Fritjof Bornebusch
On Wed, Jul 30, 2014 at 09:26:54PM +0100, Dimitris Papastamos wrote: > On Wed, Jul 30, 2014 at 10:19:19PM +0200, Fritjof Bornebusch wrote: > > + tzone = (int)strtonum(h, -23, 23, &errstr); > > The explicit cast is not needed here. > That's maybe true, but I don't like implicit casts. :)

Re: [PATCH] Better overflow handling in rcstime.c

2014-07-30 Thread Dimitris Papastamos
On Wed, Jul 30, 2014 at 10:19:19PM +0200, Fritjof Bornebusch wrote: > + tzone = (int)strtonum(h, -23, 23, &errstr); The explicit cast is not needed here.

[PATCH] Better overflow handling in rcstime.c

2014-07-30 Thread Fritjof Bornebusch
Hi tech, remove the atoi calls, in order to avoid overflows. fritjof Index: rcstime.c === RCS file: /cvs/src/usr.bin/rcs/rcstime.c,v retrieving revision 1.4 diff -u -p -r1.4 rcstime.c --- rcstime.c 29 Apr 2014 07:44:19 -