Re: [PATCH] Allow softraid crypto to work with write-protected keys

2016-05-21 Thread bytevolcano
ping On Wed, 18 May 2016 12:14:50 +0100 bytevolc...@safe-mail.net wrote: > My apologies for the noise; the previous one was the wrong revision > (r1.126 instead of 1.127) because both patches look similar; here is > the most recent catch: > > Index: sys/dev/softraid_crypto.c > ==

Re: [PATCH] Allow softraid crypto to work with write-protected keys

2016-05-18 Thread bytevolcano
My apologies for the noise; the previous one was the wrong revision (r1.126 instead of 1.127) because both patches look similar; here is the most recent catch: Index: sys/dev/softraid_crypto.c === RCS file: /cvs/src/sys/dev/softraid

Re: [PATCH] Allow softraid crypto to work with write-protected keys

2016-05-18 Thread bytevolcano
Ted Unangst wrote: > i removed these last two lines, since they were incorrect. thanks for spotting > that. however the vop_close at the end still needs updating. Thanks Ted, Also I found another stray VOP_CLOSE() setup. I have also put in the VOP_OPEN(vn, FREAD, ...) as I am not sure about 100%

Re: [PATCH] Allow softraid crypto to work with write-protected keys

2016-05-17 Thread Ted Unangst
bytevolc...@safe-mail.net wrote: > > Index: sys/dev/softraid_crypto.c > === > RCS file: /cvs/src/sys/dev/softraid_crypto.c,v > retrieving revision 1.126 > diff -u -p -r1.126 softraid_crypto.c > --- sys/dev/softraid_crypto.c 12 Apr 201

Re: [PATCH] Allow softraid crypto to work with write-protected keys

2016-05-17 Thread bytevolcano
Formatting got stuffed up when sending: Index: sys/dev/softraid_crypto.c === RCS file: /cvs/src/sys/dev/softraid_crypto.c,v retrieving revision 1.126 diff -u -p -r1.126 softraid_crypto.c --- sys/dev/softraid_crypto.c 12 Apr 2016 16:

Re: [PATCH] Allow softraid crypto to work with write-protected keys

2016-05-17 Thread bytevolcano
I have also noticed that bioctl reports the key disk as incorrect. I initially thought it was my patch, but it seems to be wrong whether or not my patch is applied. In fact the contents of the disk do not change at all: # bioctl softraid0 Volume Status Size Device softraid0 0 Onl

[PATCH] Allow softraid crypto to work with write-protected keys

2016-05-16 Thread bytevolcano
Softraid currently opens the key disk as read + write. This isn't necessary when just *reading* from the key disk. This patch allows for softraid crypto to mount volumes with write-protected keydisks (eg. Kanguru Flash Blu: https://www.kanguru.com/storage-accessories/flash-blu30.shtml). Also test