Re: [PATCH] When appropriate, replace the waitpid calls with wait in sbin/init/init.c

2023-07-17 Thread rhl120
I understand that wait and waitpid are only wrappers around wait4 but I was talking about the arguments passed to the wrappers themselves (aka 3 for waitpid and 1 for wait) but I understand your decision, thanks for the feedback. Have a nice day.

Re: [PATCH] When appropriate, replace the waitpid calls with wait in sbin/init/init.c

2023-07-17 Thread rhl120
Hello, this commit fixes nothing. To me it is just an instance of using the right tool for the right job. I could also argue that there is a performance improvement (because the call passes less arguments) but that is probably negligible. I personally would not consider the modified code to be l

[PATCH] When appropriate, replace the waitpid calls with wait in sbin/init/init.c

2023-07-17 Thread rhl120
Hello, while browsing the source code of init, I found a couple of calls to waitpid which, I believe, could be replaced with wait(NULL). As far as I can tell lib/libc/gen/wait.c and lib/libc/gen/waitpid.c backup my belief but on the other hand I am very new to this stuff so I may be wrong so sor