#x27;t have
to manually patch the source code for every release.
If you have any suggestions for improvement, just let me know. And if
this isn't the right place for this kind of patch, please kindly
redirect me.
Thanks,
Jordan Bancino
Index: get_names.c
ed my copy of rcctl.sh
off of the github mirror a few hours ago.
Does this diff look reasonable? Or should I stop tinkering? These changes
passed my rudimentary testing and also got a clean bill of health from
shellcheck.
Regards,
Jordan
--- a/rcctl.sh Sat May 1 12:07:06 20
Army is coming soon. I'm sure noone is against this patch then.
>
> The code in typeset() function, which is responsible for almost all
> shell variable tweaking, contains a bug: in case of array it passes
> "foo=var" instead of only variable name ("foo"), if th
On 1/26/21 12:13 PM, Stuart Henderson wrote:
> On 2021/01/26 11:18, Jordan Geoghegan wrote:
>>
>> On 1/26/21 5:47 AM, Stuart Henderson wrote:
>>> On 2021/01/25 00:53, Sebastian Benoit wrote:
>>>> Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:2
arbitrary file
>>> names.
>> And we already have -z for "force grep to behave as zgrep".
> sigh.. OK I guess we are better skipping the short flag and just use --null
>
>> Diff below with tedu@ suggestion and changed manpage text.
> ok with me. if I was committing I would whine about the stupid flag in
> commit log ;)
>
> [snip]
Why is a short flag not being included? '-z' and '-0' are both available in our
grep.
Jordan
#x27; (lowercase) is
currently unused/invalid in our grep.
FWIW, I agree that the '--null' long option naming is annoying and gross. There
does appear to be somewhat of a precedent for use of '-0' with grep-like tools.
The ripgrep tool forgoes '-z/-Z' and instead opts for '-0' and the '--null'
long option.
Regards,
Jordan
On 12/30/20 4:59 AM, Stuart Henderson wrote:
> On 2020/12/30 00:12, Jordan Geoghegan wrote:
>> Hello,
>>
>> I noticed some dead links on the octeon.html page for the Portwell and Rhino
>> devices.
>>
>> The Portwell link has been pointed to archive.
s I'm almost certain
that Thunderbird will mangle the long lines.
Regards,
Jordan
diff --git a/octeon.html b/octeon.html
index 7c812cae8..4926cc67c 100644
--- a/octeon.html
+++ b/octeon.html
@@ -59,14 +59,14 @@ local disk on machines lacking a CF slot.
OpenBSD/octeon supports the followin
On 12/18/20 5:04 PM, Jordan Geoghegan wrote:
On 12/17/20 3:15 AM, Otto Moerbeek wrote:
Hi,
as noted on misc dig does not like to talk to local link addresses.
This fixes that case. While investigating I also found another bug:
selecting v6 or v4 addresses only from resolv.conf via the -4
IN A 129.128.5.194
;; Query time: 853 msec
;; SERVER: fe80::f29f:c2ff:fe17:b8b2%em0#53(fe80::f29f:c2ff:fe17:b8b2%1)
;; WHEN: Fri Dec 18 19:58:57 EST 2020
;; MSG SIZE rcvd: 56
This looks good to me, hoping this can go in.
Regards,
Jordan
g like this:
find /tmp/1 -type f -name "*" -print0 | xargs -0 -I{} cp {} /tmp/2/
No GNU stuff needed.
Regards,
Jordan
in base. I like knowing the OpenBSD folks have
stripped out a lot of the cruft. I shouldn't need Python and an HTTP
parsing library just to run a modest little local resolver -- Just my
two cents.
Regards,
Jordan
On 2020-10-08 16:39, Klemens Nanni wrote:
On Thu, Oct 08, 2020 at 04:23:53PM -0700, Jordan Geoghegan wrote:
This improved error message would have been useful a few months ago where I
had a number of end-users of one of my scripts get confused due to the
cryptic error messages spit out by
sages spit out by doas.
Regards,
Jordan
On 2020-10-08 16:09, Klemens Nanni wrote:
In case `cmd' and `args' in doas.conf(5) do not match, the generated
log message is unclear and might be read as if the command executed but
failed, i.e. returned non-zero:
# cat /etc/doas
Ok updated the new changes.
On Mon, Oct 05, 2020 at 09:54:02PM +0200, Mark Kettenis wrote:
> > Date: Thu, 17 Sep 2020 20:54:51 -0500
> > From: Jordan Hargrave
> > Cc: ma...@peereboom.org, kette...@openbsd.org, tech@openbsd.org,
> > d...@openbsd.org, j...@open
Ping... still need more eyes on this
This is the IOMMU code for VT-d and AMD Vi implementation
It overrides the DMA Tag for each device and assigns it to a
protected domain
On Thu, Sep 17, 2020 at 08:54:51PM -0500, Jordan Hargrave wrote:
> Ok made more changes
>
> On Mon, Sep 14, 2
Ping. Can anyone review this?
From: Jordan Hargrave
Sent: Tuesday, September 15, 2020 12:54 PM
To: tech@openbsd.org ; jor...@openbsd.org
; kette...@openbsd.org
Subject: PATCH: Add vmmpci device for passthrough PCI
This adds a placeholder vmmpci device that
Ok made more changes
On Mon, Sep 14, 2020 at 08:19:18PM +0200, Mark Kettenis wrote:
> > Date: Tue, 8 Sep 2020 21:43:39 -0500
> > From: Jordan Hargrave
> >
> > Made changes for the iommu_readq -> iommu_read_8 and also now
> > dynamically allocate the hwdte f
Ping. Any replies or commeents on this?
On Tue, Sep 15, 2020 at 12:54:49PM -0500, Jordan Hargrave wrote:
> This adds a placeholder vmmpci device that will be used for VMD passthrough
> PCI.
>
> Normally the device will fail to attach unless the PCI domain:bus.dev.func has
> been
$ */
+/*
+ * Copyright (c) 2020 Jordan Hargrave
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "
This patch adds a couple of entries for AMD IOMMU structure definitions in ACPI
Index: acpireg.h
===
RCS file: /cvs/src/sys/dev/acpi/acpireg.h,v
retrieving revision 1.45
diff -u -p -r1.45 acpireg.h
--- acpireg.h 28 Aug 2019 22:39:09
On 2020-08-10 08:49, Jeremie Courreges-Anglas wrote:
On Sun, Aug 09 2020, Ross L Richardson wrote:
At present, if a request contains no "Host:" header [HTTP pre-1.1] or
if the supplied header does not match any of the servers configured
in httpd.conf, the request is directed to the first ser
This patch adds an extra size/cookie argument to pci_add_device and pci_add_bar.
Changes required for implementing passthrough PCI.
diff --git a/usr.sbin/vmd/pci.c b/usr.sbin/vmd/pci.c
index 954235eb6..47a133b9a 100644
--- a/usr.sbin/vmd/pci.c
+++ b/usr.sbin/vmd/pci.c
@@ -39,6 +39,26 @@ extern cha
Made changes for the iommu_readq -> iommu_read_8 and also now dynamically
allocate
the hwdte for AMD IOMMU.
On Fri, Sep 04, 2020 at 09:17:18PM +0200, Mark Kettenis wrote:
> > Date: Fri, 4 Sep 2020 00:50:44 -0500
> > From: Jordan Hargrave
>
> A few hints below...
>
&g
>From cba617464c71f4d4e4a34728f117ca92145f746f Mon Sep 17 00:00:00 2001
From: Jordan Hargrave
Date: Tue, 18 Aug 2020 15:46:36 -0500
Subject: [PATCH 1/4] Add helper vm_find_vcpu function for VMM
---
sys/arch/amd64/amd64/vmm.c | 63 --
1 file changed,
This code fixes the pci device union for accessing PCI config space >= 0x40
Running pcidump -xxx in a virtual machine would return garbage data due to
union overlap
On Mon, Sep 07, 2020 at 05:52:55PM -0500, Jordan Hargrave wrote:
> Index:
Index: pci.h
===
RCS file: /cvs/src/usr.sbin/vmd/pci.h,v
retrieving revision 1.7
diff -u -p -u -r1.7 pci.h
--- pci.h 17 Sep 2017 23:07:56 - 1.7
+++ pci.h 7 Sep 2020 22:48:09 -
@@ -32,43 +32,44 @@ typedef int (*
Attaching the full diff
On Mon, Sep 07, 2020 at 01:09:12PM -0500, Jordan Hargrave wrote:
> On Thu, Sep 03, 2020 at 08:37:56PM +0200, Mark Kettenis wrote:
> > > Date: Wed, 2 Sep 2020 15:19:55 +1000
> > > From: Jonathan Gray
> > >
> > > On Tue, Sep 01, 20
On Thu, Sep 03, 2020 at 08:37:56PM +0200, Mark Kettenis wrote:
> > Date: Wed, 2 Sep 2020 15:19:55 +1000
> > From: Jonathan Gray
> >
> > On Tue, Sep 01, 2020 at 11:44:03PM -0500, Jordan Hargrave wrote:
> > > This patch adds a common function for scanning PC
On Thu, Sep 03, 2020 at 09:06:59PM +0200, Mark Kettenis wrote:
> > Date: Tue, 1 Sep 2020 17:20:19 -0500
> > From: Jordan Hargrave
> >
> > [PATCH] Add IOMMU support for Intel VT-d and AMD Vi
> >
> > This hooks each pci device and overrides bus_dmamap_xxx t
On Wed, Sep 02, 2020 at 03:19:55PM +1000, Jonathan Gray wrote:
> On Tue, Sep 01, 2020 at 11:44:03PM -0500, Jordan Hargrave wrote:
> > This patch adds a common function for scanning PCIE Express Capability list
> > The PCIE Capability list starts at 0x100 in extended PCI configura
Oh good catch thanks. Weird, it does compile!
From: Daniel Dickman
Sent: Tuesday, September 1, 2020 11:23 PM
To: Jordan Hargrave
Cc: tech@openbsd.org
Subject: Re: [PATCH] Add IOMMU support for Intel VT-d and AMD-Vi
> [PATCH] Add IOMMU support for Intel V
This patch adds a common function for scanning PCIE Express Capability list
The PCIE Capability list starts at 0x100 in extended PCI configuration space.
---
sys/dev/pci/pci.c| 28
sys/dev/pci/pcivar.h | 2 ++
2 files changed, 30 insertions(+)
diff --git a/sys/d
ull
+++ b/sys/dev/acpi/acpidmar.c
@@ -0,0 +1,2988 @@
+/*
+ * Copyright (c) 2015 Jordan Hargrave
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
This patch is part of the PCI Passthrough VMM changes.
This adds support for registering 64-bit MMIO regions and properly handles
calculating BAR size for variable-lenth MMIO/IO regions.
Verification via pcidump -v
---
usr.sbin/vmd/pci.c | 69 +-
1 fi
---
sys/arch/amd64/amd64/vmm.c | 63 --
1 file changed, 33 insertions(+), 30 deletions(-)
diff --git a/sys/arch/amd64/amd64/vmm.c b/sys/arch/amd64/amd64/vmm.c
index 84fcb23a5..f6d51737e 100644
--- a/sys/arch/amd64/amd64/vmm.c
+++ b/sys/arch/amd64/amd64/vmm.c
@@
This is the first patch for adding PCI passthrough support to VMD.
I am splitting up the necessary changes into smaller patches.
This code fixes the pci device union for accessing PCI config space >= 0x40
pcidump -xxx would return garbage data due to union overlap
pci_add_bar now requires speci
This patch adds support to VMM to support passthrough PCI. I have tested
this on both Intel/AMD boxes, it requires the DMAR/IOMMU diff patch.
It has worked so far with re0 network devices and azalia sound but would
like more eyes and testing on this as well.
In order to build this you need to cop
Hello,
This is my first diff I've submitted here, so I imagine there's a dozen
things I'm missing/clueless about.
I've been making an effort to start browsing the tree and reading the
code regularly. I came across this file, I know it's a regress test, so
there may be some context/history I'
On 2020-03-16 06:01, Renaud Allard wrote:
On 3/15/20 9:53 PM, Stuart Henderson wrote:
On 2020/03/15 19:05, Renaud Allard wrote:
On 15/03/2020 17:36, Stuart Henderson wrote:
Lots of churn again.. most of the new + are related to the new rpz and
serve-stale support. I've been running it f
On 5/23/19 2:35 PM, Job Snijders wrote:
On Thu, May 23, 2019 at 19:50 Denis wrote:
SCTP(4) present in FreeBSD 12.0
OpenBSD implementation planned?
Nothing planned as far as I know.
Out of curiosity - what is your use case? Do you really use it? It doesn’t
seem to be a widely used protoco
On 4/1/19 9:03 AM, Kevin Chadwick wrote:
On 4/1/19 3:18 PM, Mateusz Guzik wrote:
While I support pf removal, I don't think bpf is the way to go.
FreeBSD just removed their pf [1] so the code is up for grabs and you
can import it with one weird trick.
[1] https://lists.freebsd.org/pipermail/s
Hi, All
Hope to learn more info. and one day be a part of the open community.
LeRoy Jordan
MaxStream TV
lero...@maxstreamtv.com
a/sys/dev/acpi/acpidmar.c b/sys/dev/acpi/acpidmar.c
new file mode 100755
index 000..29baf46
--- /dev/null
+++ b/sys/dev/acpi/acpidmar.c
@@ -0,0 +1,1943 @@
+/*
+ * Copyright (c) 2015 Jordan Hargrave
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or w
acpidmar.c
diff -N dev/acpi/acpidmar.c
--- /dev/null 1 Jan 1970 00:00:00 -
+++ dev/acpi/acpidmar.c 22 Jul 2015 20:25:36 -
@@ -0,0 +1,1872 @@
+/*
+ * Copyright (c) 2015 Jordan Hargrave
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or withou
you will need to fix AMLOP_ONES as well. It does a (char)opcode typecast,
which would be 0xff not 0x... if using uint64.
amlop_match, amlop_wait, amlop_acquire, amlop_condref all will need to return
AML_ONES or AML_TRUE
> Date: Sun, 1 Apr 2012 10:45:55 +0300
> From: p...@irofti.net
> To: o...
Strings are always called with -1 (to pull the size-field from strlen itself)
for creation. So technically that could be any large constant as well.
> To: o...@drijf.net
> CC: tech@openbsd.org; kette...@openbsd.org; chas...@skynet.be;
jor...@openbsd.org
> Subject: Re: aml: Fix integer types to be
This patch fixes CondRef store to empty target seen on Dell E4310 and
some HP systems. Please test and send dmesg output.
Index: dsdt.c
===
RCS file: /cvs/src/sys/dev/acpi/dsdt.c,v
retrieving revision 1.185
diff -u -p -b -r1.185 dsdt
This diff creates a common aml_dereference function, please test on as many
systems as possible and send dmesg
Index: acpiprt.c
===
RCS file: /cvs/src/sys/dev/acpi/acpiprt.c,v
retrieving revision 1.43
diff -u -p -b -r1.43 acpiprt.c
-
This patch changes the values of boolean comparisons from 0:1 to 0:-1 (from
ACPI Spec) in order to fix an AML issue on some Asus machines.
Please test on other machines as well to verify that hardware sensors/acpi/boot
work properly.
Index: dsdt.c
It looks like there is a new L06 bios for the L401X, can you try this?
> Date: Wed, 22 Dec 2010 16:08:54 -0500
> From: kwesterb...@rogers.com
> To: tech@openbsd.org
> CC: jor...@openbsd.org; mlar...@openbsd.org; ma...@openbsd.org;
kette...@openbsd.org
> Subject: New acpi challenges! New Dell XPS b
Bad AML. Looks like it is trying to do an AML Load of a memory block, and that
is failing.
Usually that's because the checksum is incorrect. Look at dsdt.c:aml_load()
and put printf's at both goto fails', to see what is failing.
Not much I can do about it now as I am in Pal
Redux: this new version will apply with -current
This patch will allow acpiec to initialize earlier if a ECDT table is
found. This fixes a lockup if booting on some Thinkpads while docked.
You can tell if your system supports ECDT by scanning the ACPI tables
line in dmesg. There should be a li
This patch will allow acpiec to initialize earlier if a ECDT table is
found. This fixes a lockup if booting on some Thinkpads while docked.
You can tell if your system supports ECDT by scanning the ACPI tables
line in dmesg. There should be a line like this:
acpi0: tables DSDT FACP SSDT ECDT TCP
If there's no delta in dmesg, then it's good.
> Date: Thu, 22 Jul 2010 20:43:43 +0200
> From: dawed...@gmx.de
> To: jor...@openbsd.org
> Subject: Re: ACPI Name Search diff for Thinkpad, etc
>
> On Thu, 22 Jul 2010 11:10:27 -0600 (MDT)
> Jordan Hargrave wrote:
>
This patch is needed on some Thinkpads when searching 'short' name
paths (\_SB.PCI0. instead of \_SB_.PCI0.xxx)
Please test and report.
Index: dsdt.c
===
RCS file: /cvs/src/sys/dev/acpi/dsdt.c,v
retrieving revision 1.172
diff -u
This diff fixes a panic seen on Dell PEx9xx servers with the new ACPI PCI
mapping.
The _INI code was resetting the _ADR to 0x on some systems if the PCI
bus
does not exist. This caused the pci_make_tag to panic as dev/fn were 0x.
The second change is in acpiprt.. a panic was put in
.com
> To: jor...@cvs.openbsd.org
> CC: jhar...@gmail.com; tech@openbsd.org
>
> On Thu, Jul 1, 2010 at 2:53 PM, Jordan Hargrave wrote:
>> Index: dev/acpi/acpi.c
>> ===
>> RCS file: /cvs/src/sys/dev/acpi/a
penBSD: acpi.c,v 1.167 2010/07/01 01:39:39 jordan Exp $ */
/*
* Copyright (c) 2005 Thorsten Lockert
* Copyright (c) 2005 Jordan Hargrave
@@ -18,7 +18,6 @@
#include
#include
-#include
#include
#include
#include
@@ -42,6 +41,10 @@
#include
#include
+#include
+#include
+#i
.169 2010/07/01 16:23:46 thib Exp $ */
+/* $OpenBSD: acpi.c,v 1.167 2010/07/01 01:39:39 jordan Exp $ */
/*
* Copyright (c) 2005 Thorsten Lockert
* Copyright (c) 2005 Jordan Hargrave
@@ -18,7 +18,6 @@
#include
#include
-#include
#include
#include
#include
@@ -42,6 +41,10 @@
uart Henderson wrote:
> On 2010/07/01 03:37, Jordan Hargrave wrote:
>> So found the problem; on the R210 the AML code CHANGES the _HID for
>> the PCI Root Bus depending on the _OSI OS running.. UGH
>>
>> I'd had code in dsdt.c for ages that converted the _HID intege
e: /cvs/src/sys/dev/acpi/acpi.c,v
retrieving revision 1.168
diff -u -p -u -p -r1.168 acpi.c
--- acpi.c 1 Jul 2010 06:29:32 - 1.168
+++ acpi.c 1 Jul 2010 09:02:54 -
@@ -1,4 +1,4 @@
-/* $OpenBSD: acpi.c,v 1.168 2010/07/01 06:29:32 jordan Exp $ */
+/* $OpenBSD: acpi.c,v 1.167 2010
06:56:15 -
@@ -1,4 +1,4 @@
-/* $OpenBSD: acpi.c,v 1.168 2010/07/01 06:29:32 jordan Exp $ */
+/* $OpenBSD: acpi.c,v 1.167 2010/07/01 01:39:39 jordan Exp $ */
/*
* Copyright (c) 2005 Thorsten Lockert
* Copyright (c) 2005 Jordan Hargrave
@@ -18,6 +18,7 @@
#include
#include
+#include
This patch is for an issue seen with ACPI on a HP Laptop but wanted to get
some additional testing done. Some debugging prints in for now.
? acpipci.diff
? acpitz.c.fix
? condref
? msg
? passive.diff
? tzdiff
? xdiff
Index: dsdt.c
==
This patch enables passive cooling support in the ACPITZ module;
please test this if your system overheats in normal usage.
It is a little noisy for now.
a good way to test is to setup the following script:
#!/bin/sh
while [ 1 ] ; do
dmesg | tail -10
sysctl hw.setperf
sysctl hw.cpuspeed
sysctl hw.
This patch enables passive cooling support in the ACPITZ module;
please test this if your system overheats in normal usage.
It is a little noisy for now.
? acpitz.c.fix
? msg
? passive.diff
Index: acpitz.c
===
RCS file: /cvs/src/sys/d
This patch should clean up the While loop code.. it makes the code closer
to IF/ELSE loop. It sets the code pointer to the beginning of the while
loop. Doesn't really fix anything, more code cleanup.
Please test this code and report any issues.
Index: amltypes.h
===
Sending out an initial attempt at implementing C-states for APCI CPUs.
The C-states are used to implement the CPU idle loop per CPU.
Please send dmesgs of booting using this patch.
Index: acpicpu.c
===
RCS file: /cvs/src/sys/dev/acpi
Here is another attempt at the drive bay eject code.. this one will detect
if the bay is already installed and do a better job of of identifying bay
devices.
Index: acpi.c
===
RCS file: /cvs/src/sys/dev/acpi/acpi.c,v
retrieving revisi
Can you try this patch with -current? This should resolve the name
reference on the HP NX6320 system. I haven't seen any other
systems that this affects, but want to regress as much as possible.
diff -u -p -u -p -b -r1.147 dsdt.c
--- dsdt.c 27 Apr 2009 23:39:14 - 1.147
+++ dsdt.c
For those of you who have been having problems with ACPI die/panic in
aml_xconvert (Could not convert!)
Can you try this patch against -current? This is an attempt to handle
non-existing AML names in the namespace.
It will cancel execution of the current method and display an error message.
[de
71 matches
Mail list logo