Re: iked(8): simplify data in sc_sock4 and sc_sock6

2020-04-08 Thread Wataru Ashihara
e IKED_OPT_VERBOSE 0x0001 #define IKED_OPT_NOACTION 0x0002 -#define IKED_OPT_NONATT0x0004 -#define IKED_OPT_NATT 0x0008 -#define IKED_OPT_PASSIVE 0x0010 +#define IKED_OPT_PASSIVE 0x0004 #define

Re: iked(8): simplify data in sc_sock4 and sc_sock6

2020-04-04 Thread Wataru Ashihara
010 > +#define IKED_OPT_PASSIVE 0x0004 This changes internal ABI so maybe clean-build is needed. (should I avoid this?) On 2020/04/05 1:58, Wataru Ashihara wrote: > The data wich

iked(8): simplify data in sc_sock4 and sc_sock6

2020-04-04 Thread Wataru Ashihara
The data wich sc_sock4 has is a little bit complicated: sc_sock4[0], sc_sock6[0] sc_sock4[1], sc_sock6[1] no

Re: iked(8): boolify

2020-04-03 Thread Wataru Ashihara
Hi, thank you for sharing your thoughts, Tobias. On 2020/04/03 21:31 Tobias Heider wrote: > On Fri, Apr 03, 2020 at 12:52:24AM +0900, Wataru Ashihara wrote: > > It would save our time of thinking and reading the source (i.e. > > eliminate the process of "what if the variab

iked(8): fix wrong "break" placement

2020-04-02 Thread Wataru Ashihara
Found by Yasuhiro Ohishi @iij. ok? Index: sbin/iked/control.c === RCS file: /cvs/src/sbin/iked/control.c,v retrieving revision 1.28 diff -u -r1.28 control.c --- sbin/iked/control.c 22 Mar 2020 15:59:05 - 1.28 +++ sbin/iked/c

Re: iked(8): fix ntohs/htons inversion

2020-04-02 Thread Wataru Ashihara
Sorry, I forgot to set my name in the email's "From" header. I'm Wataru Ashihara. On 2020/04/03 13:11 w...@iij.ad.jp wrote: > ok? > > > Index: sbin/iked/iked.c > === > RCS file: /cvs/src/sb

iked(8): boolify

2020-04-02 Thread Wataru Ashihara
It would save our time of thinking and reading the source (i.e. eliminate the process of "what if the variable 'mobike' was 2 or more? ...aha it's just a bool"). This is still work in progress. I would continue if you maintainers are positive on this proposal. Index: sbin/iked/config.c =

iked(8): Use TAILQ_FOREACH_SAFE(3)

2020-03-09 Thread Wataru Ashihara
to improve readability. This is the first time of my commit to OpenBSD, so if I went something wrong, let me know that. Index: sbin/iked/config.c === RCS file: /cvs/src/sbin/iked/config.c,v retrieving revision 1.53 diff -u -r1.53 con