Re: ldapd: adding bsd.schema

On Thu, 10 Sep 2020 17:03:28 -0400 Aisha Tammy wrote: > On 9/10/20 2:03 AM, Robert Klein wrote: > > On Sat, 5 Sep 2020 18:47:08 -0400 > > Aisha Tammy wrote: > > > >> Sorry for the late reply. > >> > >> On 8/12/20 8:19 AM, Robert Klein wrote:

Re: ldapd: adding bsd.schema

On Sat, 5 Sep 2020 18:47:08 -0400 Aisha Tammy wrote: > Sorry for the late reply. > > On 8/12/20 8:19 AM, Robert Klein wrote: > > Hi, > > > > On Wed, 12 Aug 2020 09:00:18 +0200 > > Theo Buehler wrote: > > > >> On Tue, Aug 11, 2020 at 10:22:5

fix check of return value

Hi, on lib/libc/uuid/uuid_to_string.c the return value for asprintf is checked for -1 while the manpage only says "For all these functions if an output or encoding error occurs, a value less than 0 is returned." The patch below adjusts to code to the man page (checking for less than zero). Best

Re: ldapd(8): fix, simplify UUID timestamp code

Hi, On Fri, 21 Aug 2020 22:34:35 +1000 Jonathan Matthew wrote: > On Wed, Aug 19, 2020 at 09:28:41PM -0500, Scott Cheloha wrote: > > Hi, > > > > I was auditing the tree for odd-looking time structure usage and I > > came across the UUID code in ldapd(8), uuid.c. > > > > time_cmp() is backwards.

Re: ldapd: adding bsd.schema

Hi, On Wed, 12 Aug 2020 09:00:18 +0200 Theo Buehler wrote: > On Tue, Aug 11, 2020 at 10:22:51PM -0400, Aisha Tammy wrote: > > Another bump. > > I think this is useful and am ok with this. > > Are there any concerns? If not, I'm going to commit it tomorrow. for an sshPublicKey attribute, the

Re: ldapd: fix return values for illegal passwords

ping... On Sun, 8 Mar 2020 12:18:39 +0100 Robert Klein wrote: > Hi, > > I thought a bit more about using LDAP resultCode values and I think > some intermediate values are needed so it is clearer what happens. > > Also, I found out a clients connection hangs in the

Re: ldapd: fix return values for illegal passwords

default: rc = LDAP_STRONG_AUTH_NOT_SUPPORTED; break; } + + if (rc == LDAP_X_HANDLED_BY_LDAPE_IMSGEV) + return rc; /* don't call ldap_respond() */ done: return ldap_respond(req, rc); On Sat, 7 Mar 2020 20:30:31 +0100

Re: ldapd: fix return values for illegal passwords

On Fri, 6 Mar 2020 21:50:34 +0100 Robert Klein wrote: > Hi, > > > sorry, I simply forgot ldap_auth_sasl. > > LDAP_OTHER is a good return code for imsg failure and I really like > the idea of using the LDAP return codes right away instead of the > extra mapping. > &

Re: ldapd: fix return values for illegal passwords

't create an imsg > to the parent process handling a BSDAUTH request, this clearly is an > internal error. > > Also, you missed the case for ldap_auth_sasl. > > Diff below should change this, but it's compile tested only. > > martijn@ > > On 3/1/20 5:24 P

Re: fix ldapd/ldapctl data directory handling

xtern const char *datadir; +extern char*datadir; /* Maximum number of requests to queue per namespace during compaction. * After this many requests, we return LDAP_BUSY. > > martijn@ > > On 3/2/20 8:00 PM, Robert Klein wrote: > > Hi, > > > > in l

fix ldapd/ldapctl data directory handling

d before. Best regards Robert --- commit 6a71c90c19b5dc5850305c15696af3f14d26c168 (master) from: Robert Klein date: Mon Mar 2 18:50:12 2020 UTC fix ldapd/ldapctl data directory handling -r directive didn't work as intended in both ldapd and ldapctl. this patch replaces

ldapd: fix return values for illegal passwords

urn 49 (Invalid Credentials) on bind attempts. Best regards Robert --- commit e9fe05bf15bf216ea7759cd64f17103008e1b69e (master) from: Robert Klein date: Sun Mar 1 15:49:40 2020 UTC ldapd: fix return values for illegal p

Re: fdformat: reformat usage()

On Sun, 16 Sep 2018 22:48:01 +0100 Jason McIntyre wrote: > On Wed, Sep 12, 2018 at 05:40:49PM +0100, Jason McIntyre wrote: > > On Wed, Sep 12, 2018 at 11:50:18AM +0200, Sascha Paunovic wrote: > > > Since C99, string literal concatenation is provided, allowing the > > > number of printf() calls

Re: fdformat: reformat usage()

(sorry, if this turns up twice, first attempt didn't show up for a couple of hours; updated doc patch below) On Sun, 16 Sep 2018 22:48:01 +0100 Jason McIntyre wrote: > On Wed, Sep 12, 2018 at 05:40:49PM +0100, Jason McIntyre wrote: > > On Wed, Sep 12, 2018 at 11:50:18AM +0200, Sascha Paunovic w

Re: next step in synchronizing ber.c and ber.h

On Thu, 28 Jun 2018 09:54:34 +0200 Claudio Jeker wrote: > On Wed, Jun 27, 2018 at 06:42:58PM -0400, Rob Pierce wrote: > > The following diff makes ber.c and ber.h identical across ldap, > > ldapd, and ypldap, and slightly reduces the diff with snmpd. > > > > It covers the evolution of a few scat

[PATCH] update links to USB audio specs.

Hi, the USB audio specs seem to have changed their location. Below is a patch to update the links to the currentlocation of the specs. Best regards Robert --- sys/dev/usb/uaudio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/usb/uaudio.c b/sys/dev/usb/uaudi

fix a typo in lib/libtls/man/tls_config_verify.3

Hi, this is just a small fix for a typo in the manpage for tls_config_verify. Best regards Robert Index: tls_config_verify.3 === RCS file: /cvs/src/lib/libtls/man/tls_config_verify.3,v retrieving revision 1.3 diff -u -p -r1.3 tls_c

ldpad(8): fix deletion of individual attribute values

TL;DR: OpenBSD's ldapd(8) has issues when deleting individual attribute values. Patch below. ZHANG Huangbin reported a misbehaviour in ldapd(8)'s MOD_DELETE operation when connecting to ldapd(8) with the python-ldap library. In ldapd(8) The MOD_DELETE operation always deletes all values of an a

ldpad(8): fix LDAP_MOD_DELETE operation

Hi, ZHANG Huangbin reported a misbehavior in ldapd(8)'s MOD_DELETE operation when connecting to ldapd(8) with the python-ldap library. The MOD_DELETE operation always deletes all values of an attribute and not only those specified to be deleted in the request. (Mails from Zhang Huangbin to bugs@