the original implementation use identical logic for both ‘high’ & ‘low’,
which will cause ‘high’ & ‘low’ end up at same RB-tree node, instead of an
expected interval.
and finally, break ‘for’ loop logic
luckily all these conditions never meet in practice.
On Feb 17, 2014, at 5:14 PM, Mike Larkin
Index: uvm/uvm_pmemrange.c
===
RCS file: /cvs/src/sys/uvm/uvm_pmemrange.c,v
retrieving revision 1.37
diff -p -u -r1.37 uvm_pmemrange.c
--- uvm/uvm_pmemrange.c 6 Feb 2014 16:40:40 - 1.37
+++ uvm/uvm_pmemrange.c 13 Feb 2014 22
hope this time i get the part ‘poke claudio@’ right
a. fix a bug.
b. get rid of some junk in ‘mask_rnhead’.
c. forbid unprivileged user to insert ‘genmask' into ‘mask_rnhead'
bug is in this line
memcmp((caddr_t *)info.rti_info[RTAX_GENMASK] + 1, (caddr_t *)t->rn_key
+ 1, ((struct sockad
at, Dec 28, 2013 at 03:57:04AM +0800, Kieran Devlin wrote:
>> re-send this patch, loop in claudio@
>>
>> maybe someone could verify & commit this patch
>>
>> a. fix a bug
>> b. get rid of junk in ?mask_rnhead'
>> c. forbid unprivileged user to ins
re-send this patch, loop in claudio@
maybe someone could verify & commit this patch
a. fix a bug
b. get rid of junk in ‘mask_rnhead'
c. forbid unprivileged user to insert mask into ‘mask_rnhead'
bug is in this line
Bcmp((caddr_t *)genmask + 1, (caddr_t *)t->rn_key + 1, ((struct
sockaddr
maybe someone could verify & commit this patch
a. fix a bug
b. get rid of junk in ‘mask_rnhead'
c. forbid unprivileged user to insert mask into ‘mask_rnhead'
bug is in this line
Bcmp((caddr_t *)genmask + 1, (caddr_t *)t->rn_key + 1, ((struct
sockaddr *)t->rn_key)->sa_len)
to make this r
maybe someone could verify & commit this patch
as key domain is handled by ‘pfkey_init’, this ‘ADDDOMAIN(key)’ goes nowhere.
in fact, this ‘keydomain’ variable never exist since introduced in r1.9 of
'src/sys/kern/uipc_domain.c’ which dates back to 1999
define ‘__KAME__’ in 'src/sys/kern/uipc_do
maybe someone could verify & commit this patch
this bug was introduced in r1.28 of ‘src/sys/net/radix.c’
i found it while going through source codes
Index: sys/net/radix.c
===
RCS file: /cvs/src/sys/net/radix.c,v
retrieving revision
