Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Federico Schwindt
On Mon, Mar 12, 2012 at 1:18 PM, Mark Kettenis wrote: >> Date: Mon, 12 Mar 2012 13:45:58 +0100 >> From: Jan Klemkow >> >> The return of EINVAL on fp NULL comes from me. I think its even an >> invalid argument like the other pointers. > > We tend to take the position that it is better to crash ha

Re: NEW: libc getdelim(3) and getline(3)

2012-02-29 Thread Federico Schwindt
On Tue, Feb 28, 2012 at 10:12 AM, Jan Klemkow wrote: > Here is my diff for the renaming of the getline function in base. > Please, test it and tell me everything that is wrong with it. Thanks for the diff. I will let you know if there are any problems, otherwise it will be commited soon :) f.-

Re: usb typo 2

2011-12-15 Thread Federico Schwindt
commited. thanks. On Sun, Dec 11, 2011 at 11:09 PM, Tobias Ulmer wrote: > Fix typo, requires rain, of course > > Index: sys/dev/pci/pcidevs > === > RCS file: /home/vcs/cvs/openbsd/src/sys/dev/pci/pcidevs,v > retrieving revision 1.162

Re: usb typo 1

2011-12-15 Thread Federico Schwindt
commited. thanks. On Sun, Dec 11, 2011 at 11:07 PM, Tobias Ulmer wrote: > Fix typo in diagnostic messages > > Index: sys/dev/usb/usbdi.c > === > RCS file: /home/vcs/cvs/openbsd/src/sys/dev/usb/usbdi.c,v > retrieving revision 1.43 > d

Re: support specifying scheme/method in apache server configs

2011-07-25 Thread Federico Schwindt
>[..] > it seems a bit unfair of you to hold me to a higher standard than > the rest of the apache codebase, but ill live :) i'm not asking you to go back and change existing code but you're adding, so let's make it nice :) >> to check for `:' you can use strchr(). i believe you need an ap_pstrdu

Re: support specifying scheme/method in apache server configs

2011-07-21 Thread Federico Schwindt
On Thu, Jul 14, 2011 at 4:40 AM, David Gwynne wrote: > in my environment i have nginx in front of apache to offload ssl > and to let me easily point different parts of the uri namespace at > all crazy backends we have. this works fine except if the apache > wants to canonicalise something on the "

Re: pthread_key_delete doesn't reset values

2011-07-02 Thread Federico Schwindt
you should only do that if key is valid, not always. also specific_data might be NULL. i don't think this is correct. On Sat, Jul 2, 2011 at 4:53 PM, Mike Belopuhov wrote: > On Sat, Jul 02, 2011 at 11:04 -0400, Ted Unangst wrote: >> On Mon, Jun 27, 2011, Henry Precheur wrote: >> > According to pt